Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 14625003: expose AssertNoAllocation to api (Closed)

Created:
7 years, 7 months ago by dcarney
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev, marja
Visibility:
Public.

Description

expose AssertNoAllocation to api R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14531

Patch Set 1 #

Total comments: 4

Patch Set 2 : state is now bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -19 lines) Patch
M include/v8.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/heap.h View 1 4 chunks +10 lines, -4 lines 0 comments Download
M src/heap-inl.h View 1 2 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sven Panne
https://codereview.chromium.org/14625003/diff/1/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/14625003/diff/1/src/heap-inl.h#newcode872 src/heap-inl.h:872: return 0x10 || old_state; This is "a bit" obscure. ...
7 years, 7 months ago (2013-04-30 12:21:30 UTC) #1
marja
https://codereview.chromium.org/14625003/diff/1/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/14625003/diff/1/src/heap-inl.h#newcode872 src/heap-inl.h:872: return 0x10 || old_state; || ? Maybe you meant ...
7 years, 7 months ago (2013-04-30 13:39:29 UTC) #2
marja
https://codereview.chromium.org/14625003/diff/1/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/14625003/diff/1/src/heap-inl.h#newcode872 src/heap-inl.h:872: return 0x10 || old_state; Maybe you meant old_state || ...
7 years, 7 months ago (2013-04-30 13:42:43 UTC) #3
Sven Panne
lgtm
7 years, 7 months ago (2013-05-02 11:46:43 UTC) #4
dcarney
7 years, 7 months ago (2013-05-02 20:28:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698