expose AssertNoAllocation to api

src/heap-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 846 matching lines @@
 
 
 DisallowAllocationFailure::~DisallowAllocationFailure() {
 #ifdef DEBUG
   HEAP->disallow_allocation_failure_ = old_state_;
 #endif
 }
 
 
 #ifdef DEBUG
-AssertNoAllocation::AssertNoAllocation() {
-  Isolate* isolate = ISOLATE;
-  active_ = !isolate->optimizing_compiler_thread()->IsOptimizerThread();
-  if (active_) {
-    old_state_ = isolate->heap()->allow_allocation(false);
+AllocationScopeData EnterAllocationScope(Isolate* isolate,
+                                         bool allow_allocation) {
+  bool active = !isolate->optimizing_compiler_thread()->IsOptimizerThread();
+  if (active) {
+    bool old_state = isolate->heap()->allow_allocation(allow_allocation);
+    return 0x10 || old_state;

[Sven Panne, 2013/04/30 12:21:30]

This is "a bit" obscure. Why don't we simply remember the previous state (a
bool)?

[marja, 2013/04/30 13:39:29]

|| ? Maybe you meant |? Maybe something else?

[marja, 2013/04/30 13:42:43]

Maybe you meant old_state || 0x10? :)

   }
+  return 0;
 }
 
 
-AssertNoAllocation::~AssertNoAllocation() {
-  if (active_) HEAP->allow_allocation(old_state_);
+void ExitAllocationScope(Isolate* isolate, AllocationScopeData data) {
+  if (data) isolate->heap()->allow_allocation(data);

[Sven Panne, 2013/04/30 12:21:30]

Passing a uint8_t as a bool looks wrong. Again, a simple (remembered) bool
should be less confusing.

 }
 
 
-DisableAssertNoAllocation::DisableAssertNoAllocation() {
-  Isolate* isolate = ISOLATE;
-  active_ = !isolate->optimizing_compiler_thread()->IsOptimizerThread();
-  if (active_) {
-    old_state_ = isolate->heap()->allow_allocation(true);
-  }
+AssertNoAllocation::AssertNoAllocation()
+    : data_(EnterAllocationScope(ISOLATE, false)) {
 }
 
+AssertNoAllocation::~AssertNoAllocation() {
+  ExitAllocationScope(ISOLATE, data_);
+}
+
+DisableAssertNoAllocation::DisableAssertNoAllocation()
+  : data_(EnterAllocationScope(ISOLATE, true)) {
+}
 
 DisableAssertNoAllocation::~DisableAssertNoAllocation() {
-  if (active_) HEAP->allow_allocation(old_state_);
+  ExitAllocationScope(ISOLATE, data_);
 }
-
 #else
 
 AssertNoAllocation::AssertNoAllocation() { }
 AssertNoAllocation::~AssertNoAllocation() { }
 DisableAssertNoAllocation::DisableAssertNoAllocation() { }
 DisableAssertNoAllocation::~DisableAssertNoAllocation() { }
 
 #endif
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_INL_H_