Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1462203002: win: class VM_COUNTERS -> struct (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: class VM_COUNTERS -> struct The fields aren't accessed anyway, but clang warns that they're completely inaccessible. Also, matches all the other definitions in this file. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/0a717f0d27ffd2e84edb937e9c6400926c0e26dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M util/win/process_structs.h View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 1 month ago (2015-11-19 22:01:25 UTC) #1
Mark Mentovai
Yup, this is more correct. LGTM.
5 years, 1 month ago (2015-11-19 22:23:47 UTC) #2
scottmg
5 years, 1 month ago (2015-11-19 22:26:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a717f0d27ffd2e84edb937e9c6400926c0e26dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698