Issue 1463633002: win: Avoid some more clang complaints

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
M	client/crashpad_client_win.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	util/win/exception_handler_server.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	util/win/process_info.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/1463633002/diff/20001/client/crashpad_client_win.cc File client/crashpad_client_win.cc (right): https://codereview.chromium.org/1463633002/diff/20001/client/crashpad_client_win.cc#newcode371 client/crashpad_client_win.cc:371: ServerToClientMessage response = {{0}}; Can we just use ...

5 years, 1 month ago (2015-11-19 22:41:47 UTC) #2

scottmg

https://codereview.chromium.org/1463633002/diff/20001/client/crashpad_client_win.cc File client/crashpad_client_win.cc (right): https://codereview.chromium.org/1463633002/diff/20001/client/crashpad_client_win.cc#newcode371 client/crashpad_client_win.cc:371: ServerToClientMessage response = {{0}}; On 2015/11/19 22:41:47, Mark Mentovai ...

5 years, 1 month ago (2015-11-19 23:09:53 UTC) #3

scottmg

5 years, 1 month ago (2015-11-19 23:10:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
74e69ed5553f4a2a4678fb31af4fdb1bca62770b (presubmit successful).

Expand Messages | Collapse Messages

Issue 1463633002: win: Avoid some more clang complaints (Closed)

Description

Patch Set 1 #

Patch Set 2 : win: Avoid some other clang complaints #

Patch Set 3 : {} #

Messages