Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462153007: MD Downloads: fix up some Polymer 1.2.3 issues and re-vulcanize (Closed)

Created:
5 years, 1 month ago by Dan Beam
Modified:
5 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update-polymer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix up some Polymer 1.2.3 issues and re-vulcanize R=michaelpg@chromium.org BUG=none TEST=new Polymer, same great downloads taste! NOPRESUBMIT=true # for long lines in crisper.js Committed: https://crrev.com/07b760aeb0f078e2e4a721240368119e60b8249d Cr-Commit-Position: refs/heads/master@{#361262}

Patch Set 1 #

Total comments: 3

Patch Set 2 : new patchset #

Messages

Total messages: 19 (9 generated)
Dan Beam
https://codereview.chromium.org/1462153007/diff/1/chrome/browser/resources/md_downloads/shared_style.css File chrome/browser/resources/md_downloads/shared_style.css (right): https://codereview.chromium.org/1462153007/diff/1/chrome/browser/resources/md_downloads/shared_style.css#newcode10 chrome/browser/resources/md_downloads/shared_style.css:10: display: none !important; yeah, this is gonna be annoying
5 years, 1 month ago (2015-11-21 04:20:18 UTC) #1
michaelpg
lgtm assuming the paper-header-panel removal doesn't affect behavior when resized or anything like that https://codereview.chromium.org/1462153007/diff/1/chrome/browser/resources/md_downloads/shared_style.css ...
5 years, 1 month ago (2015-11-21 04:28:00 UTC) #2
Dan Beam
https://codereview.chromium.org/1462153007/diff/1/chrome/browser/resources/md_downloads/shared_style.css File chrome/browser/resources/md_downloads/shared_style.css (right): https://codereview.chromium.org/1462153007/diff/1/chrome/browser/resources/md_downloads/shared_style.css#newcode10 chrome/browser/resources/md_downloads/shared_style.css:10: display: none !important; On 2015/11/21 04:28:00, michaelpg wrote: > ...
5 years, 1 month ago (2015-11-23 18:47:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462153007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462153007/20001
5 years, 1 month ago (2015-11-24 00:06:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462153007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462153007/20001
5 years ago (2015-11-24 03:00:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133345)
5 years ago (2015-11-24 03:55:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462153007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462153007/20001
5 years ago (2015-11-24 04:44:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462153007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462153007/20001
5 years ago (2015-11-24 05:00:11 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 06:12:26 UTC) #18
commit-bot: I haz the power
5 years ago (2015-11-24 06:13:19 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/07b760aeb0f078e2e4a721240368119e60b8249d
Cr-Commit-Position: refs/heads/master@{#361262}

Powered by Google App Engine
This is Rietveld 408576698