Update Polymer from 1.2.1 -> 1.2.3

Update Polymer from 1.2.1 -> 1.2.3

R=michaelpg@chromium.org,apacible@chromium.org
TBR=isherman@chromium.org
BUG=none

Committed: https://crrev.com/e964354526d7f4679363644306852bca978b40f1
Cr-Commit-Position: refs/heads/master@{#361222}

[Dan Beam, 2015-11-21 03:31:55]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-11-21 03:55:17]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-21 03:56:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468623004/20001

[Dan Beam, 2015-11-21 04:26:26]

did need to fix downloads, CL here:
https://codereview.chromium.org/1462153007/

[Dan Beam, 2015-11-22 02:48:15]

+apacible any ideas why MediaRouterElementsBrowserTest.MediaRouterElementsTest
is breaking with new Polymer?

[michaelpg, 2015-11-22 03:21:40]

On 2015/11/22 02:48:15, Dan Beam wrote:
> +apacible any ideas why MediaRouterElementsBrowserTest.MediaRouterElementsTest
> is breaking with new Polymer?

I've generally found whitespace to be problematic
(media_router_container.html:94).

<span>[[
    whitespaceWithinBindingsHasIssues()
      ]]</span>

But since this used to work, we could consider it a Polymer regression...

[michaelpg, 2015-11-22 03:36:56]

On 2015/11/22 03:21:40, michaelpg wrote:
> On 2015/11/22 02:48:15, Dan Beam wrote:
> > +apacible any ideas why
MediaRouterElementsBrowserTest.MediaRouterElementsTest
> > is breaking with new Polymer?
> 
> I've generally found whitespace to be problematic
> (media_router_container.html:94).
> 
> <span>[[
>     whitespaceWithinBindingsHasIssues()
>       ]]</span>
> 
> But since this used to work, we could consider it a Polymer regression...

from testing the different regexes used to find annotations, i think this broke
as a consequence of
https://github.com/Polymer/polymer/commit/561b28b8bc05ea8603645ae24546d6c1be9...
(introduced in 1.2.2)

and is fixed as a consequence of
https://github.com/Polymer/polymer/commit/04cd18491911041d33caa69ae43e86ec245...
(which came after 1.2.3)

[apacible, 2015-11-23 18:11:16]

On 2015/11/22 03:36:56, michaelpg wrote:
> On 2015/11/22 03:21:40, michaelpg wrote:
> > On 2015/11/22 02:48:15, Dan Beam wrote:
> > > +apacible any ideas why
> MediaRouterElementsBrowserTest.MediaRouterElementsTest
> > > is breaking with new Polymer?
> > 
> > I've generally found whitespace to be problematic
> > (media_router_container.html:94).
> > 
> > <span>[[
> >     whitespaceWithinBindingsHasIssues()
> >       ]]</span>
> > 
> > But since this used to work, we could consider it a Polymer regression...
> 
> from testing the different regexes used to find annotations, i think this
broke
> as a consequence of
>
https://github.com/Polymer/polymer/commit/561b28b8bc05ea8603645ae24546d6c1be9...
> (introduced in 1.2.2)
> 
> and is fixed as a consequence of
>
https://github.com/Polymer/polymer/commit/04cd18491911041d33caa69ae43e86ec245...
> (which came after 1.2.3)

Thanks for looking into this, michaelpg.

When is 1.2.4 expected to be released? (1.2.1 -> 1.2.2 was about 2 weeks, 1.2.2
-> 1.2.3 was a couple of days)

I'm also fine with just removing the whitespace from
computeRouteInSinkListValue() if this is a blocker and we can't wait for 1.2.4;
we were just trying to avoid more >80char lines. :)

[Dan Beam, 2015-11-23 18:34:40]

On 2015/11/23 18:11:16, apacible wrote:
> On 2015/11/22 03:36:56, michaelpg wrote:
> > On 2015/11/22 03:21:40, michaelpg wrote:
> > > On 2015/11/22 02:48:15, Dan Beam wrote:
> > > > +apacible any ideas why
> > MediaRouterElementsBrowserTest.MediaRouterElementsTest
> > > > is breaking with new Polymer?
> > > 
> > > I've generally found whitespace to be problematic
> > > (media_router_container.html:94).
> > > 
> > > <span>[[
> > >     whitespaceWithinBindingsHasIssues()
> > >       ]]</span>
> > > 
> > > But since this used to work, we could consider it a Polymer regression...
> > 
> > from testing the different regexes used to find annotations, i think this
> broke
> > as a consequence of
> >
>
https://github.com/Polymer/polymer/commit/561b28b8bc05ea8603645ae24546d6c1be9...
> > (introduced in 1.2.2)
> > 
> > and is fixed as a consequence of
> >
>
https://github.com/Polymer/polymer/commit/04cd18491911041d33caa69ae43e86ec245...
> > (which came after 1.2.3)
> 
> Thanks for looking into this, michaelpg.
> 
> When is 1.2.4 expected to be released? (1.2.1 -> 1.2.2 was about 2 weeks,
1.2.2
> -> 1.2.3 was a couple of days)
> 
> I'm also fine with just removing the whitespace from
> computeRouteInSinkListValue() if this is a blocker and we can't wait for
1.2.4;
> we were just trying to avoid more >80char lines. :)

material design downloads would benefit from new iron-list changes

[Dan Beam, 2015-11-23 18:51:59]

+apacible@ for chrome/browser/resources/media_router/OWNERS

[Dan Beam, 2015-11-23 18:52:19]

dbeam@chromium.org changed reviewers:
+ apacible@chromium.org

[Dan Beam, 2015-11-23 18:52:20]

+apacible@ for realz

[apacible, 2015-11-23 18:55:56]

media router lgtm, thanks!

[michaelpg, 2015-11-23 19:05:22]

On 2015/11/23 18:55:56, apacible wrote:
> media router lgtm, thanks!

everything else lgtm... assuming you ran that grep

[Dan Beam, 2015-11-23 22:19:47]

https://codereview.chromium.org/1468623004/diff/80001/components/proximity_au...
File components/proximity_auth/webui/resources/local-state.html (right):

https://codereview.chromium.org/1468623004/diff/80001/components/proximity_au...
components/proximity_auth/webui/resources/local-state.html:72:
<span>[[getLastSyncTimeString_(enrollmentState_, "Never enrolled")]]</span>
michaelpg@: i did grep, but as Polymer itself can attest: it's hard to know all
your input, so no guarantees i found 'em all

[Dan Beam, 2015-11-23 22:20:00]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-11-23 22:20:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
apacible@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1468623004/#ps80001
(title: "local-state.html")

[commit-bot: I haz the power, 2015-11-23 22:21:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468623004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468623004/80001

[Dan Beam, 2015-11-23 22:33:04]

dbeam@chromium.org changed reviewers:
+ isherman@chromium.org

[Dan Beam, 2015-11-23 22:33:05]

TBR=isherman@ for whitespace change to components/proximity_auth

[Dan Beam, 2015-11-23 22:33:23]

Description was changed from

==========
Update Polymer from 1.2.1 -> 1.2.3

R=michaelpg@chromium.org
BUG=none
==========

to

==========
Update Polymer from 1.2.1 -> 1.2.3

R=michaelpg@chromium.org,apacible@chromium.org
TBR=isherman@chromium.org
BUG=none
==========

[Ilya Sherman, 2015-11-23 22:43:49]

LGTM, though I'm confused about the 80-col rule for Polymer now.  Is it "80-col
... sometimes"?

[Dan Beam, 2015-11-23 22:45:28]

On 2015/11/23 22:43:49, Ilya Sherman wrote:
> LGTM, though I'm confused about the 80-col rule for Polymer now.  Is it
"80-col
> ... sometimes"?

textContent bindings (i.e. <span>[[computeThing_()]]</span>) sometimes break
when wrapped :(, so basically the answer is "yes" for now

[commit-bot: I haz the power, 2015-11-24 00:00:55]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-11-24 00:01:37]

Patchset 4 (id:??) landed as
https://crrev.com/e964354526d7f4679363644306852bca978b40f1
Cr-Commit-Position: refs/heads/master@{#361222}