Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1461993002: Make addEventListener/removeEventListener arguments non-optional (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make addEventListener/removeEventListener arguments non-optional Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3rsQQJvhY8k/P2cAFq3hAwAJ BUG=353484 Committed: https://crrev.com/beb1b77d02cd17749f15d0d2b307b99db8f01c34 Cr-Commit-Position: refs/heads/master@{#361316}

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : drop the use counters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -145 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/window-legacy-event-listener.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/window-legacy-event-listener-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/XMLHttpRequest-legacy-event-listener.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/XMLHttpRequest-legacy-event-listener-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html View 1 2 1 chunk +14 lines, -50 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/event-target-arguments-expected.txt View 1 2 1 chunk +12 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/node-legacy-event-listener.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/node-legacy-event-listener-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/function-length.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/function-length-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 1 2 6 chunks +20 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.idl View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461993002/1
5 years, 1 month ago (2015-11-19 13:13:42 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/137339)
5 years, 1 month ago (2015-11-19 14:09:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461993002/40001
5 years, 1 month ago (2015-11-20 23:48:02 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138380)
5 years, 1 month ago (2015-11-21 01:36:31 UTC) #9
philipj_slow
PTAL. I will not land until the Intent has one more LGTM.
5 years, 1 month ago (2015-11-21 09:31:49 UTC) #11
philipj_slow
On 2015/11/21 09:31:49, philipj wrote: > PTAL. I will not land until the Intent has ...
5 years ago (2015-11-24 07:46:16 UTC) #12
haraken
On 2015/11/24 07:46:16, philipj wrote: > On 2015/11/21 09:31:49, philipj wrote: > > PTAL. I ...
5 years ago (2015-11-24 07:47:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461993002/40001
5 years ago (2015-11-24 08:41:00 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/98578)
5 years ago (2015-11-24 08:46:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461993002/40001
5 years ago (2015-11-24 10:02:59 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 11:34:58 UTC) #20
commit-bot: I haz the power
5 years ago (2015-11-24 11:35:40 UTC) #21
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/beb1b77d02cd17749f15d0d2b307b99db8f01c34
Cr-Commit-Position: refs/heads/master@{#361316}

Powered by Google App Engine
This is Rietveld 408576698