Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/LayoutTests/fast/js/function-length.html

Issue 1461993002: Make addEventListener/removeEventListener arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: drop the use counters Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/js/function-length.html
diff --git a/third_party/WebKit/LayoutTests/fast/js/function-length.html b/third_party/WebKit/LayoutTests/fast/js/function-length.html
index e95219b1bda4e738f06ee5cc55770bfb00de356d..147d5aba48ad5f09c5d9950c1a561912b58f165e 100644
--- a/third_party/WebKit/LayoutTests/fast/js/function-length.html
+++ b/third_party/WebKit/LayoutTests/fast/js/function-length.html
@@ -11,9 +11,8 @@ shouldBe('window.confirm.length', '0');
shouldBe('window.open.length', '2');
shouldBe('window.setTimeout.length', '1');
shouldBe('window.clearTimeout.length', '0');
-// addEventListener.length should be 2, but legacy content calls with 0 or 1
-// argument. See http://crbug.com/249598
-shouldBe('window.addEventListener.length', '0');
+shouldBe('window.addEventListener.length', '2');
+shouldBe('window.removeEventListener.length', '2');
shouldBe('window.postMessage.length', '2');
shouldBe('window.dispatchEvent.length', '1');
shouldBe('window.openDatabase.length', '4');

Powered by Google App Engine
This is Rietveld 408576698