Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1461923003: Prepare for blink bots to be moved to MB. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, haraken, ojan, peria
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare for blink bots to be moved to MB. This adds the necessary bot configs and builder entries for tryserver.blink and chromium.webkit so that we can flip all of the bots to MB. Among other things, this'll allow us to benchmark different combinations of oilpan and trybot flags more easily. R=phajdan.jr@chromium.org BUG=481692 Committed: https://crrev.com/be0467558b55ef55c2dc46551e604570de802af8 Cr-Commit-Position: refs/heads/master@{#364086}

Patch Set 1 #

Patch Set 2 : merge to head, fill in rest #

Patch Set 3 : adjust asan config names #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -11 lines) Patch
M tools/mb/mb_config.pyl View 1 2 7 chunks +90 lines, -11 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Dirk Pranke
Please take a look? This CL must land before https://codereview.chromium.org/1507193004/ can land. This change by ...
5 years ago (2015-12-09 03:21:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461923003/40001
5 years ago (2015-12-09 03:29:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 04:45:42 UTC) #7
Paweł Hajdan Jr.
LGTM w/comment https://codereview.chromium.org/1461923003/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1461923003/diff/40001/tools/mb/mb_config.pyl#newcode117 tools/mb/mb_config.pyl:117: # 'tbd': ['none'], It's commented out anyway, ...
5 years ago (2015-12-09 11:04:43 UTC) #8
Dirk Pranke
https://codereview.chromium.org/1461923003/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1461923003/diff/40001/tools/mb/mb_config.pyl#newcode117 tools/mb/mb_config.pyl:117: # 'tbd': ['none'], On 2015/12/09 11:04:43, Paweł Hajdan Jr. ...
5 years ago (2015-12-09 16:47:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461923003/40001
5 years ago (2015-12-09 16:48:33 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-09 16:56:34 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-09 16:57:33 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be0467558b55ef55c2dc46551e604570de802af8
Cr-Commit-Position: refs/heads/master@{#364086}

Powered by Google App Engine
This is Rietveld 408576698