Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1461863002: Handle arbitrary heights in GlassBrowserFrameView. (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle arbitrary heights in GlassBrowserFrameView. BUG=none TEST=none Committed: https://crrev.com/e0a0671112eb09fe29acc392b5f2e75a3012a655 Cr-Commit-Position: refs/heads/master@{#360637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 4 chunks +28 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Peter Kasting
The location bar, and thus the toolbar, can have a height arbitrary smaller than the ...
5 years, 1 month ago (2015-11-19 00:37:05 UTC) #2
Peter Kasting
I found out how to test the animation stuff here; it can indeed happen with ...
5 years, 1 month ago (2015-11-19 08:49:45 UTC) #3
sky
LGTM
5 years, 1 month ago (2015-11-19 17:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461863002/1
5 years, 1 month ago (2015-11-19 18:53:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 19:05:35 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 19:06:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0a0671112eb09fe29acc392b5f2e75a3012a655
Cr-Commit-Position: refs/heads/master@{#360637}

Powered by Google App Engine
This is Rietveld 408576698