Handle arbitrary heights in GlassBrowserFrameView.

chrome/browser/ui/views/frame/glass_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/glass_browser_frame_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/windows_version.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 326 matching lines @@
   // so that the region above the tab's hit-test zone matches) versus the shadow
   // thickness.
   const int exclusion = GetLayoutConstant(TAB_TOP_EXCLUSION_HEIGHT);
   return (frame()->IsMaximized() && !restored) ?
       (top - GetLayoutInsets(TAB).top() + 1) :
       (top + kNonClientRestoredExtraThickness - exclusion);
 }
 
 void GlassBrowserFrameView::PaintToolbarBackground(gfx::Canvas* canvas) {
   gfx::Rect toolbar_bounds(browser_view()->GetToolbarBounds());
+  if (toolbar_bounds.IsEmpty())
+    return;
   gfx::Point toolbar_origin(toolbar_bounds.origin());
   ConvertPointToTarget(browser_view(), this, &toolbar_origin);
   toolbar_bounds.set_origin(toolbar_origin);
   const int h = toolbar_bounds.height();
   ui::ThemeProvider* tp = GetThemeProvider();
 
   // Background.
-  gfx::ImageSkia* bg = tp->GetImageSkiaNamed(IDR_THEME_TOOLBAR);
   int x = toolbar_bounds.x();
   const int y = toolbar_bounds.y();
   int w = toolbar_bounds.width();
 
-  const int split_point = kContentEdgeShadowThickness;
-  const int split_y =
-      y + (browser_view()->IsTabStripVisible() ? split_point : 0);
-  const int bg_y = GetTopInset(false) + Tab::GetYInsetForActiveTabBackground();
-  canvas->TileImageInt(*bg, x + GetThemeBackgroundXInset(), split_y - bg_y, x,
-                       split_y, w, bg->height());
+  // The top stroke is drawn using the IDR_CONTENT_TOP_XXX images, which overlay
+  // the toolbar.  The top 2 px of these images is the actual top stroke +
+  // shadow, and is partly transparent, so the toolbar background shouldn't be
+  // drawn over it.
+  const int split_point = std::min(kContentEdgeShadowThickness, h);
+  if (h > split_point) {
+    // Tile the toolbar image starting at the frame edge on the left and where
+    // the tabstrip is on the top.
+    const int split_y =
+        y + (browser_view()->IsTabStripVisible() ? split_point : 0);
+    const int bg_y =
+        GetTopInset(false) + Tab::GetYInsetForActiveTabBackground();
+    canvas->TileImageInt(*tp->GetImageSkiaNamed(IDR_THEME_TOOLBAR),
+                         x + GetThemeBackgroundXInset(), split_y - bg_y, x,
+                         split_y, w, h - split_point);
+  }
 
   if (browser_view()->IsTabStripVisible()) {
     // On Windows 10+ where we don't draw our own window border but rather go
     // right to the system border, the toolbar has no corners or side strokes.
     if (base::win::GetVersion() < base::win::VERSION_WIN10) {
       // Mask out the corners.
       gfx::ImageSkia* left = tp->GetImageSkiaNamed(IDR_CONTENT_TOP_LEFT_CORNER);
       const int img_w = left->width();
       x -= kContentEdgeShadowThickness;
       SkPaint paint;
       paint.setXfermodeMode(SkXfermode::kDstIn_Mode);
       canvas->DrawImageInt(
-          *tp->GetImageSkiaNamed(IDR_CONTENT_TOP_LEFT_CORNER_MASK), x, y,
-          paint);
+          *tp->GetImageSkiaNamed(IDR_CONTENT_TOP_LEFT_CORNER_MASK), 0, 0, img_w,
+          h, x, y, img_w, h, false, paint);
       const int right_x =
           toolbar_bounds.right() + kContentEdgeShadowThickness - img_w;
       canvas->DrawImageInt(
-          *tp->GetImageSkiaNamed(IDR_CONTENT_TOP_RIGHT_CORNER_MASK), right_x, y,
-          paint);
+          *tp->GetImageSkiaNamed(IDR_CONTENT_TOP_RIGHT_CORNER_MASK), 0, 0,
+          img_w, h, right_x, y, img_w, h, false, paint);
 
       // Corner and side strokes.
-      canvas->DrawImageInt(*left, x, y);
+      canvas->DrawImageInt(*left, 0, 0, img_w, h, x, y, img_w, h, false);
       canvas->DrawImageInt(*tp->GetImageSkiaNamed(IDR_CONTENT_TOP_RIGHT_CORNER),
-                           right_x, y);
+                           0, 0, img_w, h, right_x, y, img_w, h, false);
 
       x += img_w;
       w = right_x - x;
     }
 
     // Top stroke.
-    gfx::ImageSkia* toolbar_center =
-        tp->GetImageSkiaNamed(IDR_CONTENT_TOP_CENTER);
-    canvas->TileImageInt(*toolbar_center, x, y, w, toolbar_center->height());
+    canvas->TileImageInt(*tp->GetImageSkiaNamed(IDR_CONTENT_TOP_CENTER), x, y,
+                         w, split_point);
   }
 
   // Toolbar/content separator.
   const SkColor separator_color =
       tp->GetColor(ThemeProperties::COLOR_TOOLBAR_SEPARATOR);
   if (ui::MaterialDesignController::IsModeMaterial()) {
     toolbar_bounds.Inset(kClientEdgeThickness, 0);
     BrowserView::Paint1pxHorizontalLine(canvas, separator_color,
                                         toolbar_bounds);
   } else {
     toolbar_bounds.Inset(kClientEdgeThickness, h - kClientEdgeThickness,
                          kClientEdgeThickness, 0);
     canvas->FillRect(toolbar_bounds, separator_color);
   }
 }
 
 void GlassBrowserFrameView::PaintRestoredClientEdge(gfx::Canvas* canvas) {
   ui::ThemeProvider* tp = GetThemeProvider();
   int y = frame()->client_view()->y();
 
   gfx::Rect client_bounds = CalculateClientAreaBounds();
   const int x = client_bounds.x();
   const int w = client_bounds.width();
   const int right = client_bounds.right();
   const SkColor toolbar_color = tp->GetColor(ThemeProperties::COLOR_TOOLBAR);
 
-  // The client edges start below the toolbar upper corner images regardless
-  // of how tall the toolbar itself is.
-  y += browser_view()->GetToolbarBounds().y() +
-      tp->GetImageSkiaNamed(IDR_CONTENT_TOP_LEFT_CORNER)->height();
+  // The client edges start below the toolbar.
+  y += browser_view()->GetToolbarBounds().bottom();
 
   const int bottom = std::max(y, height() - NonClientBorderThickness(false));
   int height = bottom - y;
 
   // Draw the client edge images.
   gfx::ImageSkia* right_image = tp->GetImageSkiaNamed(IDR_CONTENT_RIGHT_SIDE);
   const int img_w = right_image->width();
   canvas->TileImageInt(*right_image, right, y, img_w, height);
   canvas->DrawImageInt(*tp->GetImageSkiaNamed(IDR_CONTENT_BOTTOM_RIGHT_CORNER),
                        right, bottom);
@@ skipping 174 matching lines @@
   static bool initialized = false;
   if (!initialized) {
     for (int i = 0; i < kThrobberIconCount; ++i) {
       throbber_icons_[i] =
           ui::LoadThemeIconFromResourcesDataDLL(IDI_THROBBER_01 + i);
       DCHECK(throbber_icons_[i]);
     }
     initialized = true;
   }
 }