Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1461833002: Clean up BUILD gn target of telemetry_perf_unittests, telemetry_gpu_unittests, (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up BUILD gn target of telemetry_perf_unittests, telemetry_gpu_unittests, telemetry_tests Also remove telemetry_perf_unittests on win xp platform since we no longer support win xp on perf waterfall. BUG=507796 Committed: https://crrev.com/52be542322e406f1fb0c07222ff886321f0f63e3 Cr-Commit-Position: refs/heads/master@{#360591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -48 lines) Patch
M chrome/test/BUILD.gn View 3 chunks +0 lines, -44 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/chrome_telemetry_build/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461833002/1
5 years, 1 month ago (2015-11-19 05:02:53 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 05:34:54 UTC) #5
nednguyen
5 years, 1 month ago (2015-11-19 05:48:49 UTC) #7
Paweł Hajdan Jr.
LGTM
5 years, 1 month ago (2015-11-19 15:14:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461833002/1
5 years, 1 month ago (2015-11-19 15:49:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 15:55:04 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/52be542322e406f1fb0c07222ff886321f0f63e3 Cr-Commit-Position: refs/heads/master@{#360591}
5 years, 1 month ago (2015-11-19 15:56:00 UTC) #13
Ken Russell (switch to Gerrit)
5 years, 1 month ago (2015-11-19 19:38:25 UTC) #14
Message was sent while issue was closed.
Thanks for cleaning this up. LGTM after the fact.

Powered by Google App Engine
This is Rietveld 408576698