Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/test/BUILD.gn

Issue 1461833002: Clean up BUILD gn target of telemetry_perf_unittests, telemetry_gpu_unittests, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/chromium.win.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index e043aa173674b77a20cadb8a0ce4aeef725ede3f..c67c97249ff4c144aafa739bef201541f20d8a0a 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -672,19 +672,6 @@ if (!is_android) {
"//testing/xvfb.py",
"//testing/scripts/run_telemetry_as_googletest.py",
]
-
- if (is_win && (symbol_level == 1 || symbol_level == 2)) {
- # TODO(GYP): These should be provided automatically through data_deps.
- data += [ "$root_out_dir/chrome.exe.pdb" ]
- if (is_component_build) {
- data += [
- "$root_out_dir/base.dll.pdb",
- "$root_out_dir/blink_platform.dll.pdb",
- "$root_out_dir/blink_web.dll.pdb",
- "$root_out_dir/content.dll.pdb",
- ]
- }
- }
}
# TODO(GYP): Delete this after we've converted everything to GN.
@@ -702,29 +689,11 @@ if (!is_android) {
]
data = [
- "//tools/perf/",
-
- # Field trial config
- "//tools/variations/",
-
# For isolate contract.
"//testing/scripts/common.py",
"//testing/xvfb.py",
"//testing/scripts/run_telemetry_as_googletest.py",
]
-
- if (is_win && (symbol_level == 1 || symbol_level == 2)) {
- # TODO(GYP): These should be provided automatically through data_deps.
- data += [ "$root_out_dir/chrome.exe.pdb" ]
- if (is_component_build) {
- data += [
- "$root_out_dir/base.dll.pdb",
- "$root_out_dir/blink_platform.dll.pdb",
- "$root_out_dir/blink_web.dll.pdb",
- "$root_out_dir/content.dll.pdb",
- ]
- }
- }
}
# TODO(GYP): Delete this after we've converted everything to GN.
@@ -752,19 +721,6 @@ if (!is_android) {
"//third_party/webgl/",
"//content/test/gpu/run_gpu_test.py",
]
-
- if (is_win && (symbol_level == 1 || symbol_level == 2)) {
- # TODO(GYP): These should be provided automatically through data_deps.
- data += [ "$root_out_dir/chrome.exe.pdb" ]
- if (is_component_build) {
- data += [
- "$root_out_dir/base.dll.pdb",
- "$root_out_dir/blink_platform.dll.pdb",
- "$root_out_dir/blink_web.dll.pdb",
- "$root_out_dir/content.dll.pdb",
- ]
- }
- }
}
group("telemetry_gpu_unittests_run") {
« no previous file with comments | « no previous file | testing/buildbot/chromium.win.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698