Issue 14615011: Revert 198675 "Reland 198495 for Windows."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14615011: Revert 198675 "Reland 198495 for Windows." (Closed)

Created:
7 years, 7 months ago by tommi1

Modified:
7 years, 7 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 198675 "Reland 198495 for Windows." > Reland 198495 for Windows. > > > Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed. > > > > This requires updating .isolate files for some try bots. > > In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it. > > > > BUG=238207 > > R=csharp@chromium.org, ronghuawu@chromium.org > > > > Review URL: https://codereview.chromium.org/14907003 > > TBR=tommi@chromium.org > > Review URL: https://codereview.chromium.org/14767016 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198809

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -55 lines)			Patch
M	trunk/src/chrome/browser_tests.isolate	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/chrome.isolate	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	trunk/src/chrome/interactive_ui_tests.isolate	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/sync_integration_tests.isolate	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/unit_tests.isolate	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/content/content_browsertests.isolate	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	trunk/src/content/content_unittests.isolate	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/third_party/libjingle/libjingle.gyp	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	trunk/src/third_party/libjingle/overrides/init_webrtc.cc	View	2 chunks	+0 lines, -19 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r198809.