Issue 14907003: Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the all…

Issue 14907003: Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the all… (Closed)

Created:
7 years, 7 months ago by tommi (sloooow) - chröme

Modified:
7 years, 7 months ago

Reviewers:
Ronghua Wu (Left Chromium), csharp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed. This requires updating .isolate files for some try bots. In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it. BUG=238207 R=csharp@chromium.org, ronghuawu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198495

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -14 lines)			Patch
M	chrome/browser_tests.isolate	View	1 2	3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/chrome.isolate	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/interactive_ui_tests.isolate	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/sync_integration_tests.isolate	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/unit_tests.isolate	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	content/content_browsertests.isolate	View	1 2	3 chunks	+4 lines, -1 line	0 comments	Download
M	content/content_unittests.isolate	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View		3 chunks	+9 lines, -6 lines	0 comments	Download
M	third_party/libjingle/overrides/init_webrtc.cc	View	1 2 3	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

Ronghua: libjingle changes. csharp: .isolate files

7 years, 7 months ago (2013-05-06 11:24:56 UTC) #1

tommi1

Committed patchset #4 manually as r198495 (presubmit successful).

7 years, 7 months ago (2013-05-06 18:59:20 UTC) #4

Josh Horwich

7 years, 7 months ago (2013-05-07 00:27:46 UTC) #5

Message was sent while issue was closed.

On 2013/05/06 18:59:20, tommi1 wrote:
> Committed patchset #4 manually as r198495 (presubmit successful).

Drive-by from Chrome Gardener for ChromeOS: Today we were seeing some problems
on chromium waterfall running chromiumos VMTests, for example:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...
- digging into the results tarball we'd see chrome crashing at
[1:1:0506/145854:FATAL:init_webrtc.cc(83)] Check failed: lib.

When this was reverted the problem went away. Just letting you know for when
this gets re-landed.

Expand Messages | Collapse Messages