Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1461403002: SkPDF: add `final` keyword to leaf classes (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: add `final` keyword to leaf classes Committed: https://skia.googlesource.com/skia/+/70d1554d8ea08ddb887550f98b9cfd0afd395d65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M src/pdf/SkDeflate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFontImpl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFFormXObject.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFGraphicState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461403002/1
5 years, 1 month ago (2015-11-20 18:51:26 UTC) #2
hal.canary
PTAL
5 years, 1 month ago (2015-11-20 18:51:42 UTC) #4
mtklein
lgtm
5 years, 1 month ago (2015-11-20 18:55:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 21:32:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461403002/1
5 years, 1 month ago (2015-11-22 20:39:42 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 20:55:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/70d1554d8ea08ddb887550f98b9cfd0afd395d65

Powered by Google App Engine
This is Rietveld 408576698