src/pdf/SkPDFMetadata.cpp - Issue 1461403002: SkPDF: add `final` keyword to leaf classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFMetadata.cpp

Issue 1461403002: SkPDF: add `final` keyword to leaf classes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFMetadata.cpp

diff --git a/src/pdf/SkPDFMetadata.cpp b/src/pdf/SkPDFMetadata.cpp

index 4865deb11e47c4c17e287c90bb59303a2461c861..3f181f5d73b95c436688abf8e7c3e7e54e7b0b78 100644

--- a/src/pdf/SkPDFMetadata.cpp

+++ b/src/pdf/SkPDFMetadata.cpp

@@ -183,7 +183,7 @@ static SkString uuid_to_string(const SkPDFMetadata::UUID& uuid) {

#undef HEXIFY

namespace {

-class PDFXMLObject : public SkPDFObject {

+class PDFXMLObject final : public SkPDFObject {

public:

PDFXMLObject(SkString xml) : fXML(skstd::move(xml)) {}

void emitObject(SkWStream* stream,

« no previous file with comments | « src/pdf/SkPDFGraphicState.h ('k') | src/pdf/SkPDFShader.h » ('j') | no next file with comments »