Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1461313004: Make FixContributor asynchronous. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -481 lines) Patch
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 4 chunks +28 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 2 chunks +25 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 3 chunks +30 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 5 chunks +30 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 328 chunks +442 lines, -435 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 1 month ago (2015-11-20 21:17:25 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1461313004/diff/1/pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart File pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart (right): https://codereview.chromium.org/1461313004/diff/1/pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart#newcode23 pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart:23: abstract class DartFixContext { Why not extend FixContext? ...
5 years, 1 month ago (2015-11-20 22:12:00 UTC) #2
scheglov
https://codereview.chromium.org/1461313004/diff/1/pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart File pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart (right): https://codereview.chromium.org/1461313004/diff/1/pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart#newcode23 pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart:23: abstract class DartFixContext { On 2015/11/20 22:11:59, Brian Wilkerson ...
5 years, 1 month ago (2015-11-20 22:56:08 UTC) #3
scheglov
5 years, 1 month ago (2015-11-20 22:57:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bb1914e1750c2465cf9ddb2ffdce2e1924379b10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698