Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: pkg/analysis_server/test/edit/fixes_test.dart

Issue 1461313004: Make FixContributor asynchronous. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweaks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/edit/fixes_test.dart
diff --git a/pkg/analysis_server/test/edit/fixes_test.dart b/pkg/analysis_server/test/edit/fixes_test.dart
index 531bf43bc69bc7203bee6e3b3ff723248bf6ff89..fb2ee76a91fd828cd664a55bb6f1727cb60ce000 100644
--- a/pkg/analysis_server/test/edit/fixes_test.dart
+++ b/pkg/analysis_server/test/edit/fixes_test.dart
@@ -33,14 +33,14 @@ class FixesTest extends AbstractAnalysisTest {
handler = new EditDomainHandler(server);
}
- Future test_fixUndefinedClass() async {
+ test_fixUndefinedClass() async {
addTestFile('''
main() {
Future<String> x = null;
}
''');
await waitForTasksFinished();
- List<AnalysisErrorFixes> errorFixes = _getFixesAt('Future<String>');
+ List<AnalysisErrorFixes> errorFixes = await _getFixesAt('Future<String>');
expect(errorFixes, hasLength(1));
AnalysisError error = errorFixes[0].error;
expect(error.severity, AnalysisErrorSeverity.WARNING);
@@ -51,7 +51,7 @@ main() {
expect(fixes[1].message, matches('Create class'));
}
- Future test_hasFixes() async {
+ test_hasFixes() async {
addTestFile('''
foo() {
print(1)
@@ -63,20 +63,20 @@ bar() {
await waitForTasksFinished();
// print(1)
{
- List<AnalysisErrorFixes> errorFixes = _getFixesAt('print(1)');
+ List<AnalysisErrorFixes> errorFixes = await _getFixesAt('print(1)');
expect(errorFixes, hasLength(1));
_isSyntacticErrorWithSingleFix(errorFixes[0]);
}
// print(10)
{
- List<AnalysisErrorFixes> errorFixes = _getFixesAt('print(10)');
+ List<AnalysisErrorFixes> errorFixes = await _getFixesAt('print(10)');
expect(errorFixes, hasLength(2));
_isSyntacticErrorWithSingleFix(errorFixes[0]);
_isSyntacticErrorWithSingleFix(errorFixes[1]);
}
}
- Future test_overlayOnlyFile() async {
+ test_overlayOnlyFile() async {
// add an overlay-only file
{
testCode = '''
@@ -92,21 +92,21 @@ main() {
}
// ask for fixes
await waitForTasksFinished();
- List<AnalysisErrorFixes> errorFixes = _getFixesAt('print(1)');
+ List<AnalysisErrorFixes> errorFixes = await _getFixesAt('print(1)');
expect(errorFixes, hasLength(1));
_isSyntacticErrorWithSingleFix(errorFixes[0]);
}
- List<AnalysisErrorFixes> _getFixes(int offset) {
+ Future<List<AnalysisErrorFixes>> _getFixes(int offset) async {
Request request = new EditGetFixesParams(testFile, offset).toRequest('0');
- Response response = handleSuccessfulRequest(request);
+ Response response = await waitResponse(request);
var result = new EditGetFixesResult.fromResponse(response);
return result.fixes;
}
- List<AnalysisErrorFixes> _getFixesAt(String search) {
+ Future<List<AnalysisErrorFixes>> _getFixesAt(String search) async {
int offset = findOffset(search);
- return _getFixes(offset);
+ return await _getFixes(offset);
}
void _isSyntacticErrorWithSingleFix(AnalysisErrorFixes fixes) {

Powered by Google App Engine
This is Rietveld 408576698