Disk Cache: Split some time histograms in groups based...

net/disk_cache/entry_impl.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DISK_CACHE_ENTRY_IMPL_H_
 #define NET_DISK_CACHE_ENTRY_IMPL_H_
 
 #include "base/scoped_ptr.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/disk_cache/storage_block.h"
@@ skipping 83 matching lines @@
   // Handle the pending asynchronous IO count.
   void IncrementIoCount();
   void DecrementIoCount();
 
   // Set the access times for this entry. This method provides support for
   // the upgrade tool.
   void SetTimes(base::Time last_used, base::Time last_modified);
 
  private:
   enum {
-    NUM_STREAMS = 3
+     kNumStreams = 3
+  };
+
+  enum Operation {
+    kRead,
+    kWrite,
+    kSparseRead,
+    kSparseWrite
   };
 
   ~EntryImpl();
 
   // Initializes the storage for an internal or external data block.
   bool CreateDataBlock(int index, int size);
 
   // Initializes the storage for an internal or external generic block.
   bool CreateBlock(int size, Addr* address);
 
@@ skipping 21 matching lines @@
 
   // Loads the external file to this object's memory buffer.
   bool ImportSeparateFile(int index, int offset, int buf_len);
 
   // Flush the in-memory data to the backing storage.
   bool Flush(int index, int size, bool async);
 
   // Initializes the sparse control object. Returns a net error code.
   int InitSparseData();
 
+  // Generates a histogram for the time spent working on this operation.
+  void ReportIOTime(Operation op, const base::Time& start);
+
   // Logs this entry to the internal trace buffer.
   void Log(const char* msg);
 
   CacheEntryBlock entry_;     // Key related information for this entry.
   CacheRankingsBlock node_;   // Rankings related information for this entry.
   BackendImpl* backend_;      // Back pointer to the cache.
-  scoped_array<char> user_buffers_[NUM_STREAMS];  // Store user data.
-  scoped_refptr<File> files_[NUM_STREAMS + 1];  // Files to store external user
-                                                // data and key.
-  int unreported_size_[NUM_STREAMS];  // Bytes not reported yet to the backend.
+  scoped_array<char> user_buffers_[kNumStreams];  // Store user data.
+  scoped_refptr<File> files_[kNumStreams + 1];    // Files to store external
+                                                  // user data and key.
+  int unreported_size_[kNumStreams];  // Bytes not reported yet to the backend.
   bool doomed_;               // True if this entry was removed from the cache.
   scoped_ptr<SparseControl> sparse_;  // Support for sparse entries.
 
   DISALLOW_EVIL_CONSTRUCTORS(EntryImpl);
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_ENTRY_IMPL_H_