Disk Cache: Split some time histograms in groups based...

Disk Cache: Split some time histograms in groups based
on the cache size.

BUG=10727
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19256

[Nicolas Sylvain, 2009-06-25 03:29:22]

since you us (50 * 1024 * 1024) a lot, it might be nice to define a const for
it. Just a nit though.

LGTM if the comment below is ok :

http://codereview.chromium.org/146129/diff/1/3
File net/disk_cache/entry_impl.cc (left):

http://codereview.chromium.org/146129/diff/1/3#oldcode354
Line 354: if (backend_->cache_type() == net::DISK_CACHE)
You don't need this anymore?

[rvargas (doing something else), 2009-06-25 03:36:01]

Thanks.

Yes, a const for 50MB would be nice but this is supposed to be just a temporal
change, and there is not a nice place to put it (unless I define it three
times).

http://codereview.chromium.org/146129/diff/1/3
File net/disk_cache/entry_impl.cc (left):

http://codereview.chromium.org/146129/diff/1/3#oldcode354
Line 354: if (backend_->cache_type() == net::DISK_CACHE)
On 2009/06/25 03:29:22, Nicolas Sylvain wrote:
> You don't need this anymore?

Nope. This is just to prevent the media cache to interfere with the data of the
regular one. Now we have two separate histograms with the cache type embedded in
the name.

[rvargas (doing something else), 2009-06-25 16:43:50]

Actually, I removed the duplication. Could you take another look?

[Nicolas Sylvain, 2009-06-25 16:47:37]

LGTM