Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 146129: Disk Cache: Split some time histograms in groups based... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by rvargas (soon out of office)
Modified:
3 years, 9 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan OOO until 04-22-15
Visibility:
Public.

Description

Disk Cache: Split some time histograms in groups based on the cache size. BUG=10727 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19256

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -35 lines) Patch
M net/disk_cache/backend_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M net/disk_cache/entry_impl.h View 2 chunks +15 lines, -5 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 17 chunks +42 lines, -26 lines 0 comments Download
M net/disk_cache/eviction.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
rvargas (soon out of office)
5 years, 9 months ago (2009-06-25 00:51:43 UTC) #1
Nicolas Sylvain
since you us (50 * 1024 * 1024) a lot, it might be nice to ...
5 years, 9 months ago (2009-06-25 03:29:22 UTC) #2
rvargas (soon out of office)
Thanks. Yes, a const for 50MB would be nice but this is supposed to be ...
5 years, 9 months ago (2009-06-25 03:36:01 UTC) #3
rvargas (soon out of office)
Actually, I removed the duplication. Could you take another look?
5 years, 9 months ago (2009-06-25 16:43:50 UTC) #4
Nicolas Sylvain
5 years, 9 months ago (2009-06-25 16:47:37 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d