Chromium Code Reviews
Help | Chromium Project | Sign in
(8)

Issue 146129: Disk Cache: Split some time histograms in groups based... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by rvargas (OOO until 4_21)
Modified:
2 years, 10 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, darin, willchan
Visibility:
Public.

Description

Disk Cache: Split some time histograms in groups based
on the cache size.

BUG=10727
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19256

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -35 lines) Lint Patch
M net/disk_cache/backend_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M net/disk_cache/backend_impl.cc View 1 2 3 chunks +13 lines, -2 lines 0 comments 0 errors Download
M net/disk_cache/entry_impl.h View 2 chunks +15 lines, -5 lines 0 comments 0 errors Download
M net/disk_cache/entry_impl.cc View 1 17 chunks +42 lines, -26 lines 0 comments 0 errors Download
M net/disk_cache/eviction.cc View 1 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 5
rvargas (OOO until 4_21)
4 years, 9 months ago #1
Nicolas Sylvain
since you us (50 * 1024 * 1024) a lot, it might be nice to ...
4 years, 9 months ago #2
rvargas (OOO until 4_21)
Thanks. Yes, a const for 50MB would be nice but this is supposed to be ...
4 years, 9 months ago #3
rvargas (OOO until 4_21)
Actually, I removed the duplication. Could you take another look?
4 years, 9 months ago #4
Nicolas Sylvain
4 years, 9 months ago #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6