Revert of [Oilpan] Prepare full definition of classes before using Member

Revert of [Oilpan] Prepare full definition of classes before using Member (patchset #7 id:120001 of https://codereview.chromium.org/1455943002/ )

Reason for revert:
This CL had two problems.

1) This CL regressed performance for 10% in some tests.
BUG=559311
2) This CL led compile error on win_blink_oilpan_dbg.

Original issue's description:
> Prepare full definition of classes before using Member<T>
>
> What we want to do is to instantiate some templates of
> <T> with T's full definition, in Member<T>::get() and
> Member<T>::checkPointer().
> To guarantee that template instantiations come after
> T's definition, we put static_assert() in Member<T>.
> See the change in platform/heap/Handle.h.
>
> To achieve the condition, this CL does either of
> 1) move implementation of methods using Member<T> from .h to .cpp
> 2) include necessary .h
> (1) can change inline definitions to outline definitions,
> and it may regress performance a bit.
>
> BUG=556947
>
> Committed: https://crrev.com/6486e0c8e845fc96ad9579b7c6b67e4d474f8bb2
> Cr-Commit-Position: refs/heads/master@{#360570}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@google.com,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556947
Committed: https://crrev.com/270473a30a1cabe4bc684391557494f2188b616c
Cr-Commit-Position: refs/heads/master@{#360983}

[peria, 2015-11-21 01:18:45]

Created Revert of [Oilpan] Prepare full definition of classes before using
Member

[commit-bot: I haz the power, 2015-11-21 01:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461193003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461193003/1

[commit-bot: I haz the power, 2015-11-21 01:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 01:23:13]

Failed to apply patch for
third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp:244
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp'
with conflicts.
  U third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

Patch:       third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
index
ede6666b1c5d84fa3772d10f622754a4be8bff9a..1fc9d098c705f61c0c7c0ff4a15757827586c93d
100644
--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
@@ -244,11 +244,6 @@
     return mhtmlData.release();
 }
 
-ArchiveResource* MHTMLArchive::mainResource() const
-{
-    return m_mainResource.get();
-}
-
 #if !ENABLE(OILPAN)
 void MHTMLArchive::clearAllSubframeArchives()
 {

[commit-bot: I haz the power, 2015-11-21 01:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[haraken, 2015-11-21 01:25:08]

LGTM

Yeah, it seems we need to reconsider the approach...

[peria, 2015-11-21 01:25:56]

Description was changed from

==========
Revert of [Oilpan] Prepare full definition of classes before using Member
(patchset #7 id:120001 of https://codereview.chromium.org/1455943002/ )

Reason for revert:
1) This CL regressed performance for 10% in some tests.
2) This CL happens compile error on win_blink_oilpan_dbg.


BUG=559311

Original issue's description:
> Prepare full definition of classes before using Member<T>
> 
> What we want to do is to instantiate some templates of
> <T> with T's full definition, in Member<T>::get() and
> Member<T>::checkPointer().
> To guarantee that template instantiations come after
> T's definition, we put static_assert() in Member<T>.
> See the change in platform/heap/Handle.h.
> 
> To achieve the condition, this CL does either of
> 1) move implementation of methods using Member<T> from .h to .cpp
> 2) include necessary .h
> (1) can change inline definitions to outline definitions,
> and it may regress performance a bit.
> 
> BUG=556947
> 
> Committed: https://crrev.com/6486e0c8e845fc96ad9579b7c6b67e4d474f8bb2
> Cr-Commit-Position: refs/heads/master@{#360570}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@google.com,sigbjor...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556947
==========

to

==========
Revert of [Oilpan] Prepare full definition of classes before using Member
(patchset #7 id:120001 of https://codereview.chromium.org/1455943002/ )

Reason for revert:
This CL has two problems.

1) This CL regressed performance for 10% in some tests.
BUG=559311

2) This CL led compile error on win_blink_oilpan_dbg.


Original issue's description:
> Prepare full definition of classes before using Member<T>
> 
> What we want to do is to instantiate some templates of
> <T> with T's full definition, in Member<T>::get() and
> Member<T>::checkPointer().
> To guarantee that template instantiations come after
> T's definition, we put static_assert() in Member<T>.
> See the change in platform/heap/Handle.h.
> 
> To achieve the condition, this CL does either of
> 1) move implementation of methods using Member<T> from .h to .cpp
> 2) include necessary .h
> (1) can change inline definitions to outline definitions,
> and it may regress performance a bit.
> 
> BUG=556947
> 
> Committed: https://crrev.com/6486e0c8e845fc96ad9579b7c6b67e4d474f8bb2
> Cr-Commit-Position: refs/heads/master@{#360570}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@google.com,sigbjor...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556947
==========

[peria, 2015-11-21 01:30:08]

Description was changed from

==========
Revert of [Oilpan] Prepare full definition of classes before using Member
(patchset #7 id:120001 of https://codereview.chromium.org/1455943002/ )

Reason for revert:
This CL has two problems.

1) This CL regressed performance for 10% in some tests.
BUG=559311

2) This CL led compile error on win_blink_oilpan_dbg.


Original issue's description:
> Prepare full definition of classes before using Member<T>
> 
> What we want to do is to instantiate some templates of
> <T> with T's full definition, in Member<T>::get() and
> Member<T>::checkPointer().
> To guarantee that template instantiations come after
> T's definition, we put static_assert() in Member<T>.
> See the change in platform/heap/Handle.h.
> 
> To achieve the condition, this CL does either of
> 1) move implementation of methods using Member<T> from .h to .cpp
> 2) include necessary .h
> (1) can change inline definitions to outline definitions,
> and it may regress performance a bit.
> 
> BUG=556947
> 
> Committed: https://crrev.com/6486e0c8e845fc96ad9579b7c6b67e4d474f8bb2
> Cr-Commit-Position: refs/heads/master@{#360570}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@google.com,sigbjor...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556947
==========

to

==========
Revert of [Oilpan] Prepare full definition of classes before using Member
(patchset #7 id:120001 of https://codereview.chromium.org/1455943002/ )

Reason for revert:
This CL had two problems.

1) This CL regressed performance for 10% in some tests.
BUG=559311

2) This CL led compile error on win_blink_oilpan_dbg.


Original issue's description:
> Prepare full definition of classes before using Member<T>
> 
> What we want to do is to instantiate some templates of
> <T> with T's full definition, in Member<T>::get() and
> Member<T>::checkPointer().
> To guarantee that template instantiations come after
> T's definition, we put static_assert() in Member<T>.
> See the change in platform/heap/Handle.h.
> 
> To achieve the condition, this CL does either of
> 1) move implementation of methods using Member<T> from .h to .cpp
> 2) include necessary .h
> (1) can change inline definitions to outline definitions,
> and it may regress performance a bit.
> 
> BUG=556947
> 
> Committed: https://crrev.com/6486e0c8e845fc96ad9579b7c6b67e4d474f8bb2
> Cr-Commit-Position: refs/heads/master@{#360570}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org,peria@google.com,sigbjor...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556947
==========

[peria, 2015-11-21 01:39:22]

The CQ bit was checked by peria@chromium.org

[peria, 2015-11-21 01:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1461193003/#ps140009
(title: "Make patch applicable")

[commit-bot: I haz the power, 2015-11-21 01:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461193003/140009
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461193003/140009

[commit-bot: I haz the power, 2015-11-21 01:44:33]

Committed patchset #2 (id:140009)

[commit-bot: I haz the power, 2015-11-21 01:45:32]

Patchset 2 (id:??) landed as
https://crrev.com/270473a30a1cabe4bc684391557494f2188b616c
Cr-Commit-Position: refs/heads/master@{#360983}

[esprehn, 2015-11-26 04:13:42]

Yeah please don't move all these methods out of line, lots of effort went into
making things inline around running benchmarks over the past 5 years. :)