third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h - Issue 1461193003: Revert of [Oilpan] Prepare full definition of classes before using Member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

Issue 1461193003: Revert of [Oilpan] Prepare full definition of classes before using Member (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make patch applicable Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

index d0a055d3a81c1e53d7afc3aad0c4ff29f0b69628..f05c55fb3160481fccb157381023a2e34d982634 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h

@@ -58,7 +58,12 @@ public:

struct TextPosition {

DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();

public:

- TextPosition(SVGTextPositioningElement* = nullptr, unsigned newStart = 0, unsigned newLength = 0);

+ TextPosition(SVGTextPositioningElement* newElement = nullptr, unsigned newStart = 0, unsigned newLength = 0)

+ : element(newElement)

+ , start(newStart)

+ , length(newLength)

+ {

+ }

DECLARE_TRACE();