Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Issue 1461143003: Revert of Adds TimeDomains to the TaskQueueManager (Closed)

Created:
5 years, 1 month ago by tsergeant
Modified:
5 years, 1 month ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds TimeDomains to the TaskQueueManager (patchset #18 id:330001 of https://codereview.chromium.org/1432263002/ ) Reason for revert: This CL is suspected of causing test failures on Windows and Android: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/43314 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31394 WebThreadImplForWorkerSchedulerTest.TestIdleTask is failing with FATAL:task_queue_impl.h(41)] Check failed: enqueue_order_set_. Original issue's description: > Adds TimeDomains to the TaskQueueManager > > This refactor isolates the logic dealing with delayed tasks, > making it easier to support multiple independent virtual > time sources. > > BUG=546953 > > Committed: https://crrev.com/fc164806bdf051e28d9160f6854b1782fddc5776 > Cr-Commit-Position: refs/heads/master@{#360641} TBR=skyostil@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546953 Committed: https://crrev.com/be37b6023dad3e699352e7a3e67d55d8cfe269ac Cr-Commit-Position: refs/heads/master@{#360683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -922 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/base/lazy_now.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/scheduler/base/lazy_now.cc View 1 chunk +3 lines, -0 lines 0 comments Download
D components/scheduler/base/real_time_domain.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/scheduler/base/real_time_domain.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M components/scheduler/base/task_queue.h View 4 chunks +0 lines, -12 lines 0 comments Download
M components/scheduler/base/task_queue_impl.h View 7 chunks +13 lines, -16 lines 0 comments Download
M components/scheduler/base/task_queue_impl.cc View 16 chunks +29 lines, -73 lines 0 comments Download
M components/scheduler/base/task_queue_manager.h View 6 chunks +45 lines, -17 lines 0 comments Download
M components/scheduler/base/task_queue_manager.cc View 7 chunks +153 lines, -35 lines 0 comments Download
M components/scheduler/base/task_queue_manager_unittest.cc View 5 chunks +18 lines, -100 lines 0 comments Download
M components/scheduler/base/task_queue_selector_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M components/scheduler/base/task_queue_sets_unittest.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M components/scheduler/base/test_time_source.cc View 1 chunk +1 line, -3 lines 0 comments Download
D components/scheduler/base/time_domain.h View 1 chunk +0 lines, -119 lines 0 comments Download
D components/scheduler/base/time_domain.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D components/scheduler/base/time_domain_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D components/scheduler/base/virtual_time_domain.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/scheduler/base/virtual_time_domain.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M components/scheduler/child/idle_helper.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/scheduler/child/idle_helper_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M components/scheduler/child/scheduler_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/scheduler/scheduler.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tsergeant
Created Revert of Adds TimeDomains to the TaskQueueManager
5 years, 1 month ago (2015-11-19 23:15:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461143003/1
5 years, 1 month ago (2015-11-19 23:16:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 23:20:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be37b6023dad3e699352e7a3e67d55d8cfe269ac Cr-Commit-Position: refs/heads/master@{#360683}
5 years, 1 month ago (2015-11-19 23:21:51 UTC) #4
tsergeant
5 years, 1 month ago (2015-11-19 23:31:19 UTC) #5
Message was sent while issue was closed.
There's also some failures on Linux:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...

Powered by Google App Engine
This is Rietveld 408576698