Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: components/scheduler/base/time_domain.cc

Issue 1461143003: Revert of Adds TimeDomains to the TaskQueueManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/base/time_domain.cc
diff --git a/components/scheduler/base/time_domain.cc b/components/scheduler/base/time_domain.cc
deleted file mode 100644
index 825812e43744907799923364dfc5c182a29548ec..0000000000000000000000000000000000000000
--- a/components/scheduler/base/time_domain.cc
+++ /dev/null
@@ -1,178 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/scheduler/base/time_domain.h"
-
-#include <set>
-
-#include "components/scheduler/base/task_queue_impl.h"
-#include "components/scheduler/base/task_queue_manager_delegate.h"
-#include "components/scheduler/scheduler_export.h"
-
-namespace scheduler {
-
-TimeDomain::TimeDomain() : weak_factory_(this) {}
-
-TimeDomain::~TimeDomain() {}
-
-void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) {
- // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
- // little awkward since it's keyed by time. O(n) running time.
- for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
- iter != delayed_wakeup_multimap_.end();) {
- if (iter->second == queue) {
- DelayedWakeupMultimap::iterator temp = iter;
- iter++;
- // O(1) amortized.
- delayed_wakeup_multimap_.erase(temp);
- } else {
- iter++;
- }
- }
-
- // |newly_updatable_| might contain |task_queue|, we use
- // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
- MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
- updatable_queue_set_.erase(queue);
-}
-
-void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue,
- TimeDomain* destination_time_domain) {
- LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow();
- // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
- // little awkward since it's keyed by time. O(n) running time.
- for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
- iter != delayed_wakeup_multimap_.end();) {
- if (iter->second == queue) {
- destination_time_domain->ScheduleDelayedWork(queue, iter->first,
- &destination_lazy_now);
- DelayedWakeupMultimap::iterator temp = iter;
- iter++;
- // O(1) amortized.
- delayed_wakeup_multimap_.erase(temp);
- } else {
- iter++;
- }
- }
-
- // |newly_updatable_| might contain |queue|, we use
- // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
- MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
- updatable_queue_set_.erase(queue);
-}
-
-void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue,
- base::TimeTicks delayed_run_time,
- LazyNow* lazy_now) {
- DCHECK(main_thread_checker_.CalledOnValidThread());
- // Dedupe wakeups.
- if (delayed_wakeup_multimap_.find(delayed_run_time) ==
- delayed_wakeup_multimap_.end()) {
- base::TimeDelta delay =
- std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now());
- RequestWakeup(delay);
- }
- delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue));
-}
-
-void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) {
- base::AutoLock lock(newly_updatable_lock_);
- newly_updatable_.push_back(queue);
-}
-
-void TimeDomain::UnregisterAsUpdatableTaskQueue(
- internal::TaskQueueImpl* queue) {
- DCHECK(main_thread_checker_.CalledOnValidThread());
- MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
-#ifndef NDEBUG
- {
- base::AutoLock lock(newly_updatable_lock_);
- DCHECK(!(updatable_queue_set_.find(queue) == updatable_queue_set_.end() &&
- std::find(newly_updatable_.begin(), newly_updatable_.end(),
- queue) != newly_updatable_.end()));
- }
-#endif
- updatable_queue_set_.erase(queue);
-}
-
-void TimeDomain::UpdateWorkQueues(
- bool should_trigger_wakeup,
- const internal::TaskQueueImpl::Task* previous_task) {
- DCHECK(main_thread_checker_.CalledOnValidThread());
- LazyNow lazy_now(CreateLazyNow());
-
- // Move any ready delayed tasks into the incomming queues.
- WakeupReadyDelayedQueues(&lazy_now);
-
- MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
-
- auto iter = updatable_queue_set_.begin();
- while (iter != updatable_queue_set_.end()) {
- internal::TaskQueueImpl* queue = *iter++;
- // NOTE Update work queue may erase itself from |updatable_queue_set_|.
- // This is fine, erasing an element won't invalidate any interator, as long
- // as the iterator isn't the element being delated.
- if (queue->work_queue().empty())
- queue->UpdateWorkQueue(&lazy_now, should_trigger_wakeup, previous_task);
- }
-}
-
-void TimeDomain::MoveNewlyUpdatableQueuesIntoUpdatableQueueSet() {
- DCHECK(main_thread_checker_.CalledOnValidThread());
- base::AutoLock lock(newly_updatable_lock_);
- while (!newly_updatable_.empty()) {
- updatable_queue_set_.insert(newly_updatable_.back());
- newly_updatable_.pop_back();
- }
-}
-
-void TimeDomain::WakeupReadyDelayedQueues(LazyNow* lazy_now) {
- // Wake up any queues with pending delayed work. Note std::multipmap stores
- // the elements sorted by key, so the begin() iterator points to the earliest
- // queue to wakeup.
- std::set<internal::TaskQueueImpl*> dedup_set;
- while (!delayed_wakeup_multimap_.empty()) {
- DelayedWakeupMultimap::iterator next_wakeup =
- delayed_wakeup_multimap_.begin();
- if (next_wakeup->first > lazy_now->Now())
- break;
- // A queue could have any number of delayed tasks pending so it's worthwhile
- // deduping calls to MoveReadyDelayedTasksToIncomingQueue since it takes a
- // lock. NOTE the order in which these are called matters since the order
- // in which EnqueueTaskLocks is called is respected when choosing which
- // queue to execute a task from.
- if (dedup_set.insert(next_wakeup->second).second)
- next_wakeup->second->MoveReadyDelayedTasksToIncomingQueue(lazy_now);
- delayed_wakeup_multimap_.erase(next_wakeup);
- }
-}
-
-bool TimeDomain::NextScheduledRunTime(base::TimeTicks* out_time) const {
- if (delayed_wakeup_multimap_.empty())
- return false;
-
- *out_time = delayed_wakeup_multimap_.begin()->first;
- return true;
-}
-
-bool TimeDomain::NextScheduledTaskQueue(TaskQueue** out_task_queue) const {
- if (delayed_wakeup_multimap_.empty())
- return false;
-
- *out_task_queue = delayed_wakeup_multimap_.begin()->second;
- return true;
-}
-
-void TimeDomain::AsValueInto(base::trace_event::TracedValue* state) const {
- state->BeginDictionary();
- state->SetString("name", GetName());
- state->BeginArray("updatable_queue_set");
- for (auto& queue : updatable_queue_set_)
- state->AppendString(queue->GetName());
- state->EndArray();
- AsValueIntoInternal(state);
- state->EndDictionary();
-}
-
-} // namespace scheduler
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698