Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1461073003: Keep the undefined behavior in SkDivBits until I can rebaseline layout tests. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep the undefined behavior in SkDivBits until I can rebaseline layout tests. See https://codereview.chromium.org/1455163004. BUG=skia:3562 Committed: https://crrev.com/763056ce7cee593d4fe1e8d8f5941d3a8c2dd727 Cr-Commit-Position: refs/heads/master@{#360615}

Patch Set 1 #

Patch Set 2 : SK_SUPPORT_LEGACY_DIVBITS_UB #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein_C
5 years, 1 month ago (2015-11-19 17:10:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461073003/1
5 years, 1 month ago (2015-11-19 17:11:53 UTC) #5
reed1
lgtm minor minor minor nit: would have named it SK_SUPPORT_LEGACY_... just so I can grep ...
5 years, 1 month ago (2015-11-19 17:15:54 UTC) #6
mtklein
On 2015/11/19 at 17:15:54, reed wrote: > lgtm > > minor minor minor nit: would ...
5 years, 1 month ago (2015-11-19 17:18:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461073003/20001
5 years, 1 month ago (2015-11-19 17:19:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 17:30:52 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:31:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/763056ce7cee593d4fe1e8d8f5941d3a8c2dd727
Cr-Commit-Position: refs/heads/master@{#360615}

Powered by Google App Engine
This is Rietveld 408576698