skia/config/SkUserConfig.h - Issue 1461073003: Keep the undefined behavior in SkDivBits until I can rebaseline layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/config/SkUserConfig.h

Issue 1461073003: Keep the undefined behavior in SkDivBits until I can rebaseline layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SK_SUPPORT_LEGACY_DIVBITS_UB Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: skia/config/SkUserConfig.h

diff --git a/skia/config/SkUserConfig.h b/skia/config/SkUserConfig.h

index b7260d85de3cc0ca72c7165e899942e85cb33f53..7b84e1d82903a5d92178805d401b54f699195da1 100644

--- a/skia/config/SkUserConfig.h

+++ b/skia/config/SkUserConfig.h

@@ -245,6 +245,9 @@ SK_API void SkDebugf_FileLine(const char* file, int line, bool fatal,

#define SK_ENABLE_INST_COUNT 0

#define GR_GL_CUSTOM_SETUP_HEADER "GrGLConfig_chrome.h"

+// Blink layout tests are baselined to Clang optimizing through the UB in SkDivBits.

+#define SK_SUPPORT_LEGACY_DIVBITS_UB

// ===== End Chrome-specific definitions =====

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »