Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1460913005: Fix ChromeVox Classic keyboard handling. (Closed)

Created:
5 years, 1 month ago by David Tseng
Modified:
5 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeVox Classic keyboard handling. When in classic mode, we can't eat the keys that come from the SpokenFeedbackRewriter because it needs to make its way back to the browser to be dispatched eventually to the content script, where then finally it gets handled. TEST=execute some ChromeVox commands with the same bindings between classic and next like cvox+o+(o). Committed: https://crrev.com/3f2cde1fe58068c7f9aac013078ecd9b3f357a72 Cr-Commit-Position: refs/heads/master@{#360623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
David Tseng

5 years, 1 month ago (2015-11-19 17:23:44 UTC) #3
dmazzoni
lgtm
5 years, 1 month ago (2015-11-19 17:26:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460913005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460913005/1
5 years, 1 month ago (2015-11-19 17:27:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 17:57:54 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:58:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f2cde1fe58068c7f9aac013078ecd9b3f357a72
Cr-Commit-Position: refs/heads/master@{#360623}

Powered by Google App Engine
This is Rietveld 408576698