chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 1460913005: Fix ChromeVox Classic keyboard handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1460913005: Fix ChromeVox Classic keyboard handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 4c04953b4c4de4423ef5c1fad28d83138dc4043f..e60b551bc167dd6184faa99fa5c7e8202b25399d 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -417,7 +417,8 @@ Background.prototype = {

* @return {boolean} True if the default action should be performed.

onKeyDown: function(evt) {

- if (!cvox.ChromeVoxKbHandler.basicKeyDownActionsListener(evt)) {

+ if (this.mode_ != ChromeVoxMode.CLASSIC &&

+ !cvox.ChromeVoxKbHandler.basicKeyDownActionsListener(evt)) {

evt.preventDefault();

evt.stopPropagation();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »