Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1460743002: Revert of Reland: Add code to deal with serial device disconnection detection on Windows (Closed)

Created:
5 years, 1 month ago by alph
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Add code to deal with serial device disconnection detection on Windows (patchset #16 id:300001 of https://codereview.chromium.org/1439443002/ ) Reason for revert: Broke Win GN build http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/13710 Original issue's description: > Add code to deal with serial device disconnection > detection on Windows. > > This patch added code to deal with serial device > disconnection detection problem on Windows. It gets the > COM port information from the device path and compare > the COM port information with the port information that > serial io handler holds. If they match, cancel read for > that port. > > BUG=361606 > > Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa > Cr-Commit-Position: refs/heads/master@{#360193} > > Committed: https://crrev.com/8d09d9564ea10012d55ed634c0c2835efbd8d01f > Cr-Commit-Position: refs/heads/master@{#360347} TBR=reillyg@chromium.org,grt@chromium.org,thestig@chromium.org,juncai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=361606 Committed: https://crrev.com/221127798bff4a91906781f6e862a9258cd8b9f8 Cr-Commit-Position: refs/heads/master@{#360356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -254 lines) Patch
M device/core/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/core/core.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D device/core/device_info_query_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D device/core/device_info_query_win.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M device/serial/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/serial.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/serial_io_handler.h View 2 chunks +0 lines, -12 lines 0 comments Download
M device/serial/serial_io_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/serial_io_handler_win.h View 3 chunks +0 lines, -8 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 5 chunks +4 lines, -101 lines 0 comments Download
M device/usb/usb.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/usb_service_impl.cc View 2 chunks +72 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Created Revert of Reland: Add code to deal with serial device disconnection detection on Windows
5 years, 1 month ago (2015-11-18 17:30:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460743002/1
5 years, 1 month ago (2015-11-18 17:33:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 17:35:14 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 17:35:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/221127798bff4a91906781f6e862a9258cd8b9f8
Cr-Commit-Position: refs/heads/master@{#360356}

Powered by Google App Engine
This is Rietveld 408576698