Description was changed from
==========
Add code to deal with serial device disconnection detection
This patch added code to deal with serial device disconnection detection
problem.
BUG=361606
==========
to
==========
Add code to deal with serial device disconnection detection
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
==========
juncai
Description was changed from ========== Add code to deal with serial device disconnection detection This ...
Description was changed from
==========
Add code to deal with serial device disconnection detection
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
==========
to
==========
Add code to deal with serial device disconnection
detection on Windows.
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
==========
https://codereview.chromium.org/1439443002/diff/20001/device/serial/serial_io_handler_win.cc File device/serial/serial_io_handler_win.cc (right): https://codereview.chromium.org/1439443002/diff/20001/device/serial/serial_io_handler_win.cc#newcode141 device/serial/serial_io_handler_win.cc:141: class ScopedDeviceInfoList { Let's see if we can get ...
https://codereview.chromium.org/1439443002/diff/100001/device/core/scoped_device_info_list.h File device/core/scoped_device_info_list.h (right): https://codereview.chromium.org/1439443002/diff/100001/device/core/scoped_device_info_list.h#newcode13 device/core/scoped_device_info_list.h:13: namespace base { this shouldn't be in base::win any ...
5 years, 1 month ago
(2015-11-13 19:40:05 UTC)
#16
https://codereview.chromium.org/1439443002/diff/140001/device/serial/serial_io_handler_win.cc File device/serial/serial_io_handler_win.cc (left): https://codereview.chromium.org/1439443002/diff/140001/device/serial/serial_io_handler_win.cc#oldcode169 device/serial/serial_io_handler_win.cc:169: VPLOG(1) << "Failed to set serial timeouts"; On 2015/11/14 ...
5 years, 1 month ago
(2015-11-16 21:10:34 UTC)
#20
This looks much better, thanks. Please read http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-inlining-code-in-headers and then move the non-trivial impl of ...
5 years, 1 month ago
(2015-11-17 16:06:56 UTC)
#23
the change i've been commenting on lgtm, although i'd prefer some doc comments.
5 years, 1 month ago
(2015-11-17 19:29:09 UTC)
#25
the change i've been commenting on lgtm, although i'd prefer some doc comments.
juncai
On 2015/11/17 19:29:09, grt wrote: > the change i've been commenting on lgtm, although i'd ...
5 years, 1 month ago
(2015-11-17 21:50:21 UTC)
#26
On 2015/11/17 19:29:09, grt wrote:
> the change i've been commenting on lgtm, although i'd prefer some doc
comments.
Thanks! documentation and comments added.
juncai
The CQ bit was checked by juncai@chromium.org
5 years, 1 month ago
(2015-11-17 22:49:14 UTC)
#27
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439443002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439443002/260001
5 years, 1 month ago
(2015-11-17 22:50:00 UTC)
#29
Description was changed from ========== Add code to deal with serial device disconnection detection on ...
5 years, 1 month ago
(2015-11-18 01:50:09 UTC)
#33
Message was sent while issue was closed.
Description was changed from
==========
Add code to deal with serial device disconnection
detection on Windows.
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa
Cr-Commit-Position: refs/heads/master@{#360193}
==========
to
==========
Add code to deal with serial device disconnection
detection on Windows.
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa
Cr-Commit-Position: refs/heads/master@{#360193}
==========
juncai
The CQ bit was checked by juncai@chromium.org
5 years, 1 month ago
(2015-11-18 16:43:01 UTC)
#34
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439443002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439443002/300001
5 years, 1 month ago
(2015-11-18 16:44:21 UTC)
#36
Description was changed from ========== Add code to deal with serial device disconnection detection on ...
5 years, 1 month ago
(2015-11-19 01:07:15 UTC)
#40
Message was sent while issue was closed.
Description was changed from
==========
Add code to deal with serial device disconnection
detection on Windows.
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa
Cr-Commit-Position: refs/heads/master@{#360193}
Committed: https://crrev.com/8d09d9564ea10012d55ed634c0c2835efbd8d01f
Cr-Commit-Position: refs/heads/master@{#360347}
==========
to
==========
Add code to deal with serial device disconnection
detection on Windows.
This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.
BUG=361606
Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa
Cr-Commit-Position: refs/heads/master@{#360193}
Committed: https://crrev.com/8d09d9564ea10012d55ed634c0c2835efbd8d01f
Cr-Commit-Position: refs/heads/master@{#360347}
==========
juncai
The CQ bit was checked by juncai@chromium.org
5 years, 1 month ago
(2015-11-21 05:50:15 UTC)
#41
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439443002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439443002/320001
5 years, 1 month ago
(2015-11-21 05:50:27 UTC)
#43
Issue 1439443002: Reland: Add code to deal with serial device disconnection detection on Windows
(Closed)
Created 5 years, 1 month ago by juncai
Modified 5 years, 1 month ago
Reviewers: Reilly Grant (use Gerrit), grt (UTC plus 2), Lei Zhang
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 73