Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: components/browser_sync/browser/profile_sync_components_factory_impl.h

Issue 1460723004: [Sync] Remove the last datatype-specific deps from sync_driver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_components_factory_impl.h
diff --git a/components/browser_sync/browser/profile_sync_components_factory_impl.h b/components/browser_sync/browser/profile_sync_components_factory_impl.h
index 579d1b9cb7c8d04f83fb7a7b58865ae1397f1dbd..d7ef399f5d8e3747e5a1087fd9c7807b0e58707a 100644
--- a/components/browser_sync/browser/profile_sync_components_factory_impl.h
+++ b/components/browser_sync/browser/profile_sync_components_factory_impl.h
@@ -19,6 +19,14 @@
class OAuth2TokenService;
class Profile;
+namespace autofill {
+class AutofillWebDataService;
+}
+
+namespace password_manager {
+class PasswordStore;
+}
+
namespace net {
class URLRequestContextGetter;
}
@@ -45,7 +53,9 @@ class ProfileSyncComponentsFactoryImpl
const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
const scoped_refptr<base::SingleThreadTaskRunner>& db_thread,
OAuth2TokenService* token_service,
- net::URLRequestContextGetter* url_request_context_getter);
+ net::URLRequestContextGetter* url_request_context_getter,
+ const scoped_refptr<autofill::AutofillWebDataService>& web_data_service,
+ const scoped_refptr<password_manager::PasswordStore>& password_store);
~ProfileSyncComponentsFactoryImpl() override;
// SyncApiComponentFactory implementation:
@@ -105,6 +115,11 @@ class ProfileSyncComponentsFactoryImpl
OAuth2TokenService* const token_service_;
net::URLRequestContextGetter* const url_request_context_getter_;
+ // Members that must be fetched on the UI thread but accessed on their
Nicolas Zea 2015/12/08 21:54:03 comment nit: This comment is outdated now right? T
maxbogue 2015/12/09 18:20:58 Deleted it, thanks.
+ // respective backend threads.
+ scoped_refptr<autofill::AutofillWebDataService> web_data_service_;
+ scoped_refptr<password_manager::PasswordStore> password_store_;
+
base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);

Powered by Google App Engine
This is Rietveld 408576698