[Sync] Remove the last datatype-specific deps from sync_driver.

components/password_manager/sync/browser/password_data_type_controller.h

Index: components/password_manager/sync/browser/password_data_type_controller.h
diff --git a/components/password_manager/sync/browser/password_data_type_controller.h b/components/password_manager/sync/browser/password_data_type_controller.h
index 1881eb3ceb2c425acee4586bbdfefb6a7c5a398d..6205d90a7579f75b42d99292a0eb4dee592ee5a1 100644
--- a/components/password_manager/sync/browser/password_data_type_controller.h
+++ b/components/password_manager/sync/browser/password_data_type_controller.h
@@ -30,7 +30,8 @@ class PasswordDataTypeController : public sync_driver::NonUIDataTypeController,
       const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
       const base::Closure& error_callback,
       sync_driver::SyncClient* sync_client,
-      const base::Closure& state_changed_callback);
+      const base::Closure& state_changed_callback,
+      const scoped_refptr<password_manager::PasswordStore>& password_store);

[vabr (Chromium), 2015/12/08 10:14:28]

nit: Should this be just password_manager::PasswordStore* ?
My understanding is that the (member variable) scoped_refptr is only interested
in the referenced object itself, and there changes the reference count
accordingly.

[maxbogue, 2015/12/08 19:08:05]

I can't find any style guidelines on it, but I think we prefer const & because
that way it's obvious that the pointer is ref-counted and should be stored in a
scoped_refptr.

[vabr (Chromium), 2015/12/09 09:07:14]

Sounds reasonable, LGTM.

 
   // NonFrontendDataTypeController implementation
   syncer::ModelType type() const override;
@@ -50,8 +51,8 @@ class PasswordDataTypeController : public sync_driver::NonUIDataTypeController,
 
  private:
   sync_driver::SyncClient* const sync_client_;
-  scoped_refptr<password_manager::PasswordStore> password_store_;
   const base::Closure state_changed_callback_;
+  scoped_refptr<password_manager::PasswordStore> password_store_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordDataTypeController);
 };