Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 146068: Switching decoders to use the injected message loop. (Closed)

Created:
11 years, 6 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Switching decoders to use the injected message loop. TEST=test should continue to pass, movies stay in sync BUG=none

Patch Set 1 #

Total comments: 3

Patch Set 2 : Ready for review #

Total comments: 9

Patch Set 3 : Fixed comments and unit tests #

Total comments: 4

Patch Set 4 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -210 lines) Patch
M media/base/filters.h View 3 chunks +6 lines, -0 lines 0 comments Download
M media/base/pipeline_impl.cc View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
media/filters/decoder_base.h View 1 2 3 3 chunks +166 lines, -195 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 9 chunks +23 lines, -8 lines 0 comments Download
M media/filters/test_video_decoder.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scherkus (not reviewing)
This isn't 100% polished but it's interesting nonetheless. Basically the public API starts to look ...
11 years, 6 months ago (2009-06-24 01:19:59 UTC) #1
awong
skimmed it really fast. Looking nice! If this were java, we'd be able to do ...
11 years, 6 months ago (2009-06-24 01:27:02 UTC) #2
Alpha Left Google
Looking good! http://codereview.chromium.org/146068/diff/1/3 File media/filters/decoder_base.h (right): http://codereview.chromium.org/146068/diff/1/3#newcode15 Line 15: #include "base/stl_util-inl.h" nit: reorder includes http://codereview.chromium.org/146068/diff/1/3#newcode201 ...
11 years, 6 months ago (2009-06-24 18:17:42 UTC) #3
scherkus (not reviewing)
ping!
11 years, 6 months ago (2009-06-26 17:33:06 UTC) #4
awong
couple of comments. http://codereview.chromium.org/146068/diff/1007/1009 File media/filters/decoder_base.h (right): http://codereview.chromium.org/146068/diff/1007/1009#newcode56 Line 56: scoped_refptr<Buffer> buffer_ref = buffer; Why ...
11 years, 6 months ago (2009-06-26 17:45:03 UTC) #5
scherkus (not reviewing)
The unit tests were super broken but now they're not :) http://codereview.chromium.org/146068/diff/1007/1009 File media/filters/decoder_base.h (right): ...
11 years, 5 months ago (2009-06-29 22:52:36 UTC) #6
awong
LGTM couple small comment comments. http://codereview.chromium.org/146068/diff/2001/3002 File media/base/pipeline_impl.cc (right): http://codereview.chromium.org/146068/diff/2001/3002#newcode461 Line 461: // TODO(scherkus): beware! ...
11 years, 5 months ago (2009-06-29 23:06:23 UTC) #7
scherkus (not reviewing)
11 years, 5 months ago (2009-06-29 23:16:02 UTC) #8
also added a fix for gcc + TODO

http://codereview.chromium.org/146068/diff/2001/3002
File media/base/pipeline_impl.cc (right):

http://codereview.chromium.org/146068/diff/2001/3002#newcode461
Line 461: // TODO(scherkus): beware!  this can get posted multiple times!  it
shouldn't!
On 2009/06/29 23:06:23, awong wrote:
> explain what we're supposed to do to fix?

Done.

http://codereview.chromium.org/146068/diff/2001/3003
File media/filters/decoder_base.h (right):

http://codereview.chromium.org/146068/diff/2001/3003#newcode55
Line 55: // that holds onto a reference via scoped_refptr<>.
On 2009/06/29 23:06:23, awong wrote:
> TODO to kill this

Done.

Powered by Google App Engine
This is Rietveld 408576698