Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: media/base/filters.h

Issue 146068: Switching decoders to use the injected message loop. (Closed)
Patch Set: More fixes Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/pipeline_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index 7f5913849f9b06901bd730476346ca8286a5d861..43f24fd66eb68ffb1f98f12ca0e91efc28013ec6 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -174,6 +174,8 @@ class DemuxerStream : public base::RefCountedThreadSafe<DemuxerStream> {
// Schedules a read. When the |read_callback| is called, the downstream
// filter takes ownership of the buffer by AddRef()'ing the buffer.
+ //
+ // TODO(scherkus): switch Read() callback to scoped_refptr<>.
virtual void Read(Callback1<Buffer*>::Type* read_callback) = 0;
// Given a class that supports the |Interface| and a related static method
@@ -218,6 +220,8 @@ class VideoDecoder : public MediaFilter {
virtual const MediaFormat& media_format() = 0;
// Schedules a read. Decoder takes ownership of the callback.
+ //
+ // TODO(scherkus): switch Read() callback to scoped_refptr<>.
virtual void Read(Callback1<VideoFrame*>::Type* read_callback) = 0;
};
@@ -239,6 +243,8 @@ class AudioDecoder : public MediaFilter {
virtual const MediaFormat& media_format() = 0;
// Schedules a read. Decoder takes ownership of the callback.
+ //
+ // TODO(scherkus): switch Read() callback to scoped_refptr<>.
virtual void Read(Callback1<Buffer*>::Type* read_callbasck) = 0;
};
« no previous file with comments | « no previous file | media/base/pipeline_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698