Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: components/web_contents_delegate_android/BUILD.gn

Issue 1460633005: Aura on Android: Remove unnecessary dependencies on ui/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use assert(!use_aura). Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/app/BUILD.gn » ('j') | ui/android/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_contents_delegate_android/BUILD.gn
diff --git a/components/web_contents_delegate_android/BUILD.gn b/components/web_contents_delegate_android/BUILD.gn
index 56ee8de191b4ef13dff2011dd775c35715318a73..c3d6c2f29d151a605c9a8633159a6c8c09caa3b3 100644
--- a/components/web_contents_delegate_android/BUILD.gn
+++ b/components/web_contents_delegate_android/BUILD.gn
@@ -24,11 +24,14 @@ static_library("web_contents_delegate_android") {
"//content/public/common",
"//net",
"//skia",
- "//ui/android",
"//ui/base",
"//ui/gfx",
"//ui/gfx/geometry",
]
+
+ if (!use_aura) {
+ deps += [ "//ui/android" ]
no sievers 2015/11/19 22:23:09 this should not be needed since the aura build sho
Hadi 2015/11/19 22:38:04 (I replied in the discussion thread in the bottom
+ }
}
# GYP: //components/web_contents_delegate_android:web_contents_delegate_android_java
« no previous file with comments | « no previous file | content/app/BUILD.gn » ('j') | ui/android/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698