Aura on Android: Remove unnecessary dependencies on ui/android.

components/web_contents_delegate_android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/rules.gni")
 
 # GYP: //components/web_contents_delegate_android:web_contents_delegate_android
 static_library("web_contents_delegate_android") {
   sources = [
     "color_chooser_android.cc",
     "color_chooser_android.h",
     "component_jni_registrar.cc",
     "component_jni_registrar.h",
     "validation_message_bubble_android.cc",
     "validation_message_bubble_android.h",
     "web_contents_delegate_android.cc",
     "web_contents_delegate_android.h",
   ]
 
   deps = [
     ":web_contents_delegate_android_jni_headers",
     "//base",
     "//content/public/browser",
     "//content/public/common",
     "//net",
     "//skia",
-    "//ui/android",
     "//ui/base",
     "//ui/gfx",
     "//ui/gfx/geometry",
   ]
+
+  if (!use_aura) {
+    deps += [ "//ui/android" ]

[no sievers, 2015/11/19 22:23:09]

this should not be needed since the aura build should not depend on
web_contents_delegate_android

[Hadi, 2015/11/19 22:38:04]

(I replied in the discussion thread in the bottom which didn't appear in the
inlined comments, so I am repeating it here).

Yes, I think you're right. We're depending on web_contents_delegate_android from
different places, so I thought I can do this as a temporary quick fix. If I
comment out the web_contents_delegate_android, I get the following errors:

//chrome/browser:browser(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android(//build/toolchain/android:arm)
//android_webview:common(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android(//build/toolchain/android:arm)
//chrome/android:chrome_shared_test_java__build_config(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android_java(//build/toolchain/android:arm)
//android_webview/glue:glue_resource_rewriter__build_config(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android_java_resources(//build/toolchain/android:arm)
//android_webview/native:native(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android(//build/toolchain/android:arm)
//android_webview:android_webview_java__build_config(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android_java(//build/toolchain/android:arm)
//android_webview/glue:glue__build_config(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android_java_resources(//build/toolchain/android:arm)
//chrome/android:chrome_java__build_config(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android_java(//build/toolchain/android:arm)
//chrome/test/android:chrome_java_test_support__build_config(//build/toolchain/android:arm)
  needs
//components/web_contents_delegate_android:web_contents_delegate_android_java(//build/toolchain/android:arm)

Probably we don't need some of these targets too, and I think removing each of
them will require some other changes so it will be a bigger project. Maybe I can
tackle fixing the dependency tree and removing dependency on targets we don't
need (including ui_android) as one CL if it looks high priority.

+  }
 }
 
 # GYP: //components/web_contents_delegate_android:web_contents_delegate_android_java
 android_resources("web_contents_delegate_android_java_resources") {
   custom_package = "org.chromium.components.web_contents_delegate_android"
   resource_dirs = [ "android/java/res" ]
 }
 
 # GYP: //components/web_contents_delegate_android:web_contents_delegate_android_java
 android_library("web_contents_delegate_android_java") {
   deps = [
     ":web_contents_delegate_android_java_resources",
     "//base:base_java",
     "//ui/android:ui_java",
     "//content/public/android:content_java",
     "//content/public/android:content_java_resources",
   ]
   DEPRECATED_java_in_dir = "android/java/src"
 }
 
 # GYP: //components/web_contents_delegate_android:web_contents_delegate_android_jni_headers
 generate_jni("web_contents_delegate_android_jni_headers") {
   sources = [
     "android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java",
     "android/java/src/org/chromium/components/web_contents_delegate_android/ValidationMessageBubble.java",
     "android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java",
   ]
   jni_package = "web_contents_delegate_android"
 }