third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h - Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup. tableChanged was wrong - do proper check. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

index 61093f987f905999a7854b2b5cb3e91d7965d31c..a2ad7bf2975b5890e0f981285b11926e121a95ca 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "platform/image-decoders/ImageFrame.h"

#include "third_party/skia/include/core/SkBitmap.h"

#include "wtf/PassOwnPtr.h"

#include "wtf/Vector.h"

@@ -14,7 +15,7 @@ using DecoderCreator = PassOwnPtr<ImageDecoder>(*)();

PassRefPtr<SharedBuffer> readFile(const char* fileName);

PassRefPtr<SharedBuffer> readFile(const char* dir, const char* fileName);

unsigned hashBitmap(const SkBitmap&);

-void createDecodingBaseline(DecoderCreator, SharedBuffer*, Vector<unsigned>* baselineHashes);

+void createDecodingBaseline(DecoderCreator, SharedBuffer*, Vector<unsigned>* baselineHashes, ImageFrame::ColorType outputType = ImageFrame::N32);

void testByteByByteDecode(DecoderCreator createDecoder, const char* file, size_t expectedFrameCount, int expectedRepetitionCount);

void testMergeBuffer(DecoderCreator createDecoder, const char* file);

}