Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup. tableChanged was wrong - do proper check. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
index 7b34e954408277d01e1e6ff2ec72238110a7abd4..b555d6823edfe9c614a7ed385a9624475d95efb4 100644
--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
@@ -7,7 +7,6 @@
#include "platform/SharedBuffer.h"
#include "platform/image-decoders/ImageDecoder.h"
-#include "platform/image-decoders/ImageFrame.h"
#include "public/platform/Platform.h"
#include "public/platform/WebUnitTestSupport.h"
#include "wtf/OwnPtr.h"
@@ -47,13 +46,13 @@ static unsigned createDecodingBaseline(DecoderCreator createDecoder, SharedBuffe
return hashBitmap(frame->bitmap());
}
-void createDecodingBaseline(DecoderCreator createDecoder, SharedBuffer* data, Vector<unsigned>* baselineHashes)
+void createDecodingBaseline(DecoderCreator createDecoder, SharedBuffer* data, Vector<unsigned>* baselineHashes, ImageFrame::ColorType outputType)
{
OwnPtr<ImageDecoder> decoder = createDecoder();
decoder->setData(data, true);
size_t frameCount = decoder->frameCount();
for (size_t i = 0; i < frameCount; ++i) {
- ImageFrame* frame = decoder->frameBufferAtIndex(i);
+ ImageFrame* frame = decoder->frameBufferAtIndex(i, outputType);
baselineHashes->append(hashBitmap(frame->getSkBitmap()));
}
}

Powered by Google App Engine
This is Rietveld 408576698