third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h - Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h

Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skia:onGetColorType related implementation. Fix part of Leon's review comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h ('K') | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h

index 18170f5ff537b9f497a02859ac11b30ca506c760..4580ac821fd7de10dcfdf1e5b166418873f0493a 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h

@@ -168,6 +168,7 @@ public:

}

void setDefined() { m_isDefined = true; }

bool isDefined() const { return m_isDefined; }

+ size_t getPosition() const { return m_position; }

// Build RGBA table using the data stream.

void buildTable(blink::FastSharedBufferReader*);