third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h - Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skia:onGetColorType related implementation. Fix part of Leon's review comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/images/resources/3dolph.gif ('k') | third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

index 970d74e762ce84f23ea097750ca31a04a2c99d9a..6cd2c2945245ebc0e4fb3bad0589dc0b912f6d70 100644

--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

@@ -64,6 +64,8 @@ protected:

bool onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3], SkYUVColorSpace*) override;

+ SkColorType onGetColorType() override;

Noel Gordon 2015/12/09 08:42:11 Interesting given the recent discussions on https:

aleksandar.stojiljkovic 2015/12/22 15:19:55 removed

private:

RefPtr<ImageFrameGenerator> m_frameGenerator;

size_t m_frameIndex;