third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h - Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h

Issue 1460523002: GIF decoding to Index8, unit tests and misusing unit test as benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skia:onGetColorType related implementation. Fix part of Leon's review comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h ('K') | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h

index 36075eea0959d6be46ffdc7a321fee3eca5e043f..f5e3b8e2e406a281656d278acb5ab9eae1270d89 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h

@@ -297,6 +297,10 @@ public:

virtual bool canDecodeToYUV() { return false; }

virtual bool decodeToYUV() { return false; }

virtual void setImagePlanes(PassOwnPtr<ImagePlanes>) { }

+ virtual bool canDecodeTo(size_t index, ImageFrame::ColorType outputType)

+ {

+ return outputType == ImageFrame::N32;

+ }

protected:

// Calculates the most recent frame whose image data may be needed in