Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/libxml/libxml.gyp

Issue 146043003: Start massaging the GYP files for building with clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Insert comment as suggested by thakis Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/libxml.gyp
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index 6f8b8e1b96875111e442b18e041a5ced9fd74344..a9343fd92a5c6049e207c2007dbc984530f386c3 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -233,7 +233,7 @@
}, { # else: OS!="win"
'product_name': 'xml2',
}],
- ['clang == 1', {
+ ['clang==1', {
'xcode_settings': {
'WARNING_CFLAGS': [
# libxml passes `const unsigned char*` through `const char*`.
@@ -252,6 +252,14 @@
# See http://crbug.com/138571#c8
'-Wno-ignored-attributes',
],
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ # VS2012's standard lib doesn't provide nan().
+ '/U__STDC_VERSION__',
Nico 2014/01/24 01:11:28 (why isn't this needed for cl.exe? I guess it does
+ ],
+ },
+ },
}],
],
}],
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698