Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: build/common.gypi

Issue 146043003: Start massaging the GYP files for building with clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Insert comment as suggested by thakis Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libxml/libxml.gyp » ('j') | third_party/libxml/libxml.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7bf928dfd13023e7f950aa62ff45bc1ab2c1bb9a..ab8742d5a6bb1c2c715b92537736505c95d9828d 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1923,6 +1923,11 @@
}],
],
}],
+
+ ['OS=="win" and clang==1', {
+ 'chromium_win_pch': 0,
+ }],
+
# The seccomp-bpf sandbox is only supported on three architectures
# currently.
# Do not disable seccomp_bpf anywhere without talking to
@@ -2551,6 +2556,11 @@
'VCCLCompilerTool': { 'WarnAsError': 'false' },
}
}],
+ ['clang==1', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': { 'WarnAsError': 'false' },
+ }
+ }],
],
}],
# TODO(darin): Unfortunately, some third_party code depends on base.
@@ -4657,6 +4667,53 @@
}
}],
],
+ 'conditions': [
+ ['clang==1', {
+ # Building with Clang on Windows is a work in progress and very
+ # experimental. See crbug.com/82385.
+ 'VCCLCompilerTool': {
+ 'WarnAsError': 'false',
+ 'RuntimeTypeInfo': 'false',
+ 'AdditionalOptions': [
+ '/fallback',
+
+ # Many files use intrinsics without including this header.
+ # TODO(hans): Fix those files, or move this to sub-GYPs.
+ '/FIIntrin.h',
+
+ # TODO(hans): Make this list shorter eventually.
+ '-Qunused-arguments',
+ '-Wno-c++11-compat-deprecated-writable-strings',
+ '-Wno-char-subscripts',
+ '-Wno-deprecated-declarations',
+ '-Wno-deprecated-register',
+ '-Wno-empty-body',
+ '-Wno-enum-conversion',
+ '-Wno-incompatible-pointer-types',
+ '-Wno-logical-op-parentheses',
+ '-Wno-microsoft',
+ '-Wno-missing-braces',
+ '-Wno-msvc-include',
+ '-Wno-null-dereference',
+ '-Wno-overloaded-virtual',
+ '-Wno-parentheses',
+ '-Wno-pointer-sign',
+ '-Wno-reorder',
+ '-Wno-return-type-c-linkage',
+ '-Wno-self-assign',
+ '-Wno-switch',
+ '-Wno-tautological-compare',
+ '-Wno-unknown-pragmas',
+ '-Wno-unsequenced',
+ '-Wno-unused-function',
+ '-Wno-unused-private-field',
+ '-Wno-unused-value',
+ '-Wno-unused-variable',
+ '-ferror-limit=1',
+ ],
+ },
+ }],
+ ],
},
},
}],
« no previous file with comments | « no previous file | third_party/libxml/libxml.gyp » ('j') | third_party/libxml/libxml.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698