Only flush SharedFunctionInfo optimized code cache when necessary

Only flush SharedFunctionInfo optimized code cache when necessary

R=mstarzinger@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14650

[danno, 2013-05-13 11:29:38]

PTAL

[Michael Starzinger, 2013-05-13 11:33:15]

One high-level comment.

https://codereview.chromium.org/14604007/diff/7001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/14604007/diff/7001/src/objects.h#newcode5824
src/objects.h:5824: void ClearOptimizedCodeMap(Code* optimized_code, const char*
reason);
Can we add a new EvictFromOptimizedCodeMap function instead that does the trick?
Because those are two different actions and IMHO we should have two different
entry points for that. If at some point the ClearOptmizedCodeMap is no longer
needed we can remove it completely.

[danno, 2013-05-13 11:48:22]

Please take another look.

[Michael Starzinger, 2013-05-13 14:26:45]

A couple of nits and two real comments in the objects.cc file.

https://codereview.chromium.org/14604007/diff/11001/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/arm/deoptimizer-arm.c...
src/arm/deoptimizer-arm.cc:61: // any more.  Play safe and reset the whole
cache.
The second sentence of the comment is out-dated, let's just drop it.

https://codereview.chromium.org/14604007/diff/11001/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/ia32/deoptimizer-ia32...
src/ia32/deoptimizer-ia32.cc:131: // any more.  Play safe and reset the whole
cache.
The second sentence of the comment is out-dated, let's just drop it.

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9066
src/objects.cc:9066: code_map->set(i, code_map->get(i + 1 + kEntryLength));
The indices look suspiciously off in this loop!

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9080
src/objects.cc:9080: heap->CreateFillerObjectAt(filler_start,
This will destroy live-bytes count if incremental marking is active. Please use
the RightTrimFixedArray helper instead to do the trimming.

https://codereview.chromium.org/14604007/diff/11001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/14604007/diff/11001/src/objects.h#newcode5826
src/objects.h:5826: // all code objects if |optimized_code| is null.
The second part of the comment is out-dated, let's just drop it.

https://codereview.chromium.org/14604007/diff/11001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/runtime.cc#newcode8014
src/runtime.cc:8014: // Flush optimized code cache for this function.
The comment is outdated.

https://codereview.chromium.org/14604007/diff/11001/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/x64/deoptimizer-x64.c...
src/x64/deoptimizer-x64.cc:62: // any more.  Play safe and reset the whole
cache.
The second sentence of the comment is out-dated, let's just drop it.

[danno, 2013-05-13 15:23:10]

Please take another look

https://codereview.chromium.org/14604007/diff/11001/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/arm/deoptimizer-arm.c...
src/arm/deoptimizer-arm.cc:61: // any more.  Play safe and reset the whole
cache.
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> The second sentence of the comment is out-dated, let's just drop it.

Done.

https://codereview.chromium.org/14604007/diff/11001/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/ia32/deoptimizer-ia32...
src/ia32/deoptimizer-ia32.cc:131: // any more.  Play safe and reset the whole
cache.
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> The second sentence of the comment is out-dated, let's just drop it.

Done.

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9066
src/objects.cc:9066: code_map->set(i, code_map->get(i + 1 + kEntryLength));
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> The indices look suspiciously off in this loop!

Done.

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9080
src/objects.cc:9080: heap->CreateFillerObjectAt(filler_start,
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> This will destroy live-bytes count if incremental marking is active. Please
use
> the RightTrimFixedArray helper instead to do the trimming.

Done.

https://codereview.chromium.org/14604007/diff/11001/src/objects.cc#newcode9080
src/objects.cc:9080: heap->CreateFillerObjectAt(filler_start,
Oh, this is much better! Thanks!
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> This will destroy live-bytes count if incremental marking is active. Please
use
> the RightTrimFixedArray helper instead to do the trimming.

https://codereview.chromium.org/14604007/diff/11001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/14604007/diff/11001/src/objects.h#newcode5826
src/objects.h:5826: // all code objects if |optimized_code| is null.
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> The second part of the comment is out-dated, let's just drop it.

Done.

https://codereview.chromium.org/14604007/diff/11001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/runtime.cc#newcode8014
src/runtime.cc:8014: // Flush optimized code cache for this function.
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> The comment is outdated.

Done.

https://codereview.chromium.org/14604007/diff/11001/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):

https://codereview.chromium.org/14604007/diff/11001/src/x64/deoptimizer-x64.c...
src/x64/deoptimizer-x64.cc:62: // any more.  Play safe and reset the whole
cache.
On 2013/05/13 14:26:46, Michael Starzinger wrote:
> The second sentence of the comment is out-dated, let's just drop it.

Done.

[Michael Starzinger, 2013-05-13 15:31:33]

LGTM, with one nit.

https://codereview.chromium.org/14604007/diff/19001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/14604007/diff/19001/src/objects.h#newcode5826
src/objects.h:5826: // all code objects if |optimized_code| is null.
As mentioned before, the second part of the comment is outdated, let's drop it.

[danno, 2013-05-13 19:22:26]

Committed patchset #8 manually as r14650 (presubmit successful).