Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: src/arm/deoptimizer-arm.cc

Issue 14604007: Only flush SharedFunctionInfo optimized code cache when necessary (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix bug Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 void Deoptimizer::DeoptimizeFunctionWithPreparedFunctionList( 47 void Deoptimizer::DeoptimizeFunctionWithPreparedFunctionList(
48 JSFunction* function) { 48 JSFunction* function) {
49 Isolate* isolate = function->GetIsolate(); 49 Isolate* isolate = function->GetIsolate();
50 HandleScope scope(isolate); 50 HandleScope scope(isolate);
51 AssertNoAllocation no_allocation; 51 AssertNoAllocation no_allocation;
52 52
53 ASSERT(function->IsOptimized()); 53 ASSERT(function->IsOptimized());
54 ASSERT(function->FunctionsInFunctionListShareSameCode()); 54 ASSERT(function->FunctionsInFunctionListShareSameCode());
55 55
56 // The optimized code is going to be patched, so we cannot use it
57 // any more. Play safe and reset the whole cache.
58 function->shared()->ClearOptimizedCodeMap("deoptimized function");
59
60 // Get the optimized code. 56 // Get the optimized code.
61 Code* code = function->code(); 57 Code* code = function->code();
62 Address code_start_address = code->instruction_start(); 58 Address code_start_address = code->instruction_start();
63 59
60 // The optimized code is going to be patched, so we cannot use it any more.
61 function->shared()->EvictFromOptimizedCodeMap(code, "deoptimized function");
62
64 // Invalidate the relocation information, as it will become invalid by the 63 // Invalidate the relocation information, as it will become invalid by the
65 // code patching below, and is not needed any more. 64 // code patching below, and is not needed any more.
66 code->InvalidateRelocation(); 65 code->InvalidateRelocation();
67 66
68 // For each LLazyBailout instruction insert a call to the corresponding 67 // For each LLazyBailout instruction insert a call to the corresponding
69 // deoptimization entry. 68 // deoptimization entry.
70 DeoptimizationInputData* deopt_data = 69 DeoptimizationInputData* deopt_data =
71 DeoptimizationInputData::cast(code->deoptimization_data()); 70 DeoptimizationInputData::cast(code->deoptimization_data());
72 #ifdef DEBUG 71 #ifdef DEBUG
73 Address prev_call_address = NULL; 72 Address prev_call_address = NULL;
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 __ push(ip); 823 __ push(ip);
825 __ b(&done); 824 __ b(&done);
826 ASSERT(masm()->pc_offset() - start == table_entry_size_); 825 ASSERT(masm()->pc_offset() - start == table_entry_size_);
827 } 826 }
828 __ bind(&done); 827 __ bind(&done);
829 } 828 }
830 829
831 #undef __ 830 #undef __
832 831
833 } } // namespace v8::internal 832 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698