SVGPath object "mutability" cleanup

SVGPath object "mutability" cleanup

Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
rename it to addPathByteStreams. Move the "regular" blending out into a
helper(blendPathByteStreams), and eliminate the redundant copy. Make the
functions more "functional" (return the result.)

Add a (private) setter for byte-stream data and use that to ensure
invalidation of the cached path. Also add an SVGPath::create(...)
accepting a SVGPathByteStream and use that in PathSVGInterpolation.

Inline mutableByteStream into the remaining user.

Committed: https://crrev.com/3bb121da7ff1f82996caaa73339ec41cf3672cea
Cr-Commit-Position: refs/heads/master@{#361128}

[fs, 2015-11-23 12:51:08]

Description was changed from

==========
SVGPath object "mutability" cleanup

Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
and split the blending out into a helper (blendPathByteStreams), and
eliminate the redundant copy. Make the functions more "functional"
(return the result.)

Add a (private) setter for byte-stream data and use that to ensure
invalidation of the cached path. Also add an SVGPath::create(...)
accepting a SVGPathByteStream and use that in PathSVGInterpolation.

Inline mutableByteStream into the remaining user.
==========

to

==========
SVGPath object "mutability" cleanup

Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
rename it to addPathByteStreams. Move the "regular" blending out into a
helper(blendPathByteStreams), and eliminate the redundant copy. Make the
functions more "functional" (return the result.)

Add a (private) setter for byte-stream data and use that to ensure
invalidation of the cached path. Also add an SVGPath::create(...)
accepting a SVGPathByteStream and use that in PathSVGInterpolation.

Inline mutableByteStream into the remaining user.
==========

[fs, 2015-11-23 14:08:50]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[f(malita), 2015-11-23 14:31:53]

Nice cleanup, LGTM!

https://codereview.chromium.org/1460253002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPath.cpp (right):

https://codereview.chromium.org/1460253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPath.cpp:132: byteStreamWillChange();
Nit: since we're no longer leaking a mutable bytestream out, we could tighten
the inval semantics a bit and call this after touching the bytestream (renamed
to bytestreamChanged())

[fs, 2015-11-23 15:24:56]

https://codereview.chromium.org/1460253002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPath.cpp (right):

https://codereview.chromium.org/1460253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPath.cpp:132: byteStreamWillChange();
On 2015/11/23 at 14:31:53, f(malita) wrote:
> Nit: since we're no longer leaking a mutable bytestream out, we could tighten
the inval semantics a bit and call this after touching the bytestream (renamed
to bytestreamChanged())

Done.

[fs, 2015-11-23 16:35:19]

The CQ bit was checked by fs@opera.com

[fs, 2015-11-23 16:35:19]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1460253002/#ps40001
(title: "Rebase; byteStreamWillChange->byteStreamChanged; Drop some includes.")

[commit-bot: I haz the power, 2015-11-23 16:36:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460253002/40001

[commit-bot: I haz the power, 2015-11-23 17:15:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-23 17:17:17]

Patchset 3 (id:??) landed as
https://crrev.com/3bb121da7ff1f82996caaa73339ec41cf3672cea
Cr-Commit-Position: refs/heads/master@{#361128}