third_party/WebKit/Source/core/svg/SVGPath.h - Issue 1460253002: SVGPath object "mutability" cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPath.h

Issue 1460253002: SVGPath object "mutability" cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase; byteStreamWillChange->byteStreamChanged; Drop some includes. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPath.h

diff --git a/third_party/WebKit/Source/core/svg/SVGPath.h b/third_party/WebKit/Source/core/svg/SVGPath.h

index 781f6d51952be7a6f505f6f6b288958cc84fc063..37ae4f60958337305cf04198acaeff17ea53bfe7 100644

--- a/third_party/WebKit/Source/core/svg/SVGPath.h

+++ b/third_party/WebKit/Source/core/svg/SVGPath.h

@@ -47,13 +47,16 @@ public:

{

return adoptRefWillBeNoop(new SVGPath());

}

+ static PassRefPtrWillBeRawPtr<SVGPath> create(PassOwnPtr<SVGPathByteStream> pathByteStream)

+ {

+ return adoptRefWillBeNoop(new SVGPath(pathByteStream));

+ }

~SVGPath() override;

const Path& path() const;

const SVGPathByteStream& byteStream() const;

- SVGPathByteStream& mutableByteStream();

// SVGPropertyBase:

PassRefPtrWillBeRawPtr<SVGPath> clone() const;

@@ -72,7 +75,8 @@ private:

explicit SVGPath(PassOwnPtr<SVGPathByteStream>);

SVGPathByteStream& ensureByteStream();

- void byteStreamWillChange();

+ void byteStreamChanged();

+ void setValueAsByteStream(PassOwnPtr<SVGPathByteStream>);

OwnPtr<SVGPathByteStream> m_byteStream;

mutable OwnPtr<Path> m_cachedPath;