Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: src/compiler/pipeline.cc

Issue 1460183002: [turbofan] Add general support for sp-based frame access (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm64 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index a5ae3f0def8b47e26b89c142193713c534362c44..80f5edcb7487d65e353648d2f10a2ab4b09dc0c5 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -273,7 +273,9 @@ class PipelineData {
StandardFrameConstants::kCPSlotCount
: StandardFrameConstants::kFixedSlotCount;
}
- frame_ = new (instruction_zone()) Frame(fixed_frame_size);
+ bool needs_frame = descriptor->IsJSFunctionCall() ||
+ descriptor->kind() == CallDescriptor::kCallAddress;
Benedikt Meurer 2015/11/20 09:53:10 Nit: this looks somewhat ad-hoc; can we have some
danno 2015/11/23 14:35:22 Done.
danno 2015/11/23 14:35:22 Done.
danno 2015/11/24 12:02:00 Done.
+ frame_ = new (instruction_zone()) Frame(fixed_frame_size, needs_frame);
register_allocation_data_ = new (register_allocation_zone())
RegisterAllocationData(config, register_allocation_zone(), frame(),
sequence(), debug_name);
« src/compiler/linkage.h ('K') | « src/compiler/linkage.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698